From: Sunil V L <sunilvl@ventanamicro.com>
To: qemu-riscv@nongnu.org, qemu-devel@nongnu.org
Cc: Palmer Dabbelt <palmer@dabbelt.com>,
Alistair Francis <alistair.francis@wdc.com>,
Bin Meng <bin.meng@windriver.com>,
Weiwei Li <liweiwei@iscas.ac.cn>,
Daniel Henrique Barboza <dbarboza@ventanamicro.com>,
Liu Zhiwei <zhiwei_liu@linux.alibaba.com>,
Andrea Bolognani <abologna@redhat.com>,
Sunil V L <sunilvl@ventanamicro.com>
Subject: [PATCH v7 0/3] hw/riscv/virt: pflash improvements
Date: Thu, 1 Jun 2023 10:29:07 +0530 [thread overview]
Message-ID: <20230601045910.18646-1-sunilvl@ventanamicro.com> (raw)
This series improves the pflash usage in RISC-V virt machine with solutions to
below issues.
1) Currently the first pflash is reserved for ROM/M-mode firmware code. But S-mode
payload firmware like EDK2 need both pflash devices to have separate code and variable
store so that OS distros can keep the FW code as read-only.
The issue is reported at
https://salsa.debian.org/qemu-team/edk2/-/commit/c345655a0149f64c5020bfc1e53c619ce60587f6
2) The latest way of using pflash devices in other architectures and libvirt
is by using -blockdev and machine options. However, currently this method is
not working in RISC-V.
With above issues fixed, added documentation on how to use pflash devices
in RISC-V virt machine.
This patch series is based on Alistair's riscv-to-apply.next branch.
Changes since v6:
1) Updated the documentation patch as per text provided by Andrea.
Changes since v5:
1) Added KVM use case as per feedback from Anup. Updated the documentation
patch that only S-mode payload is supported for KVM guests. Tested with
KVM enabled.
2) Updated tags.
Changes since v4:
1) Updated patch 2 to avoid accessing private field as per feedback from Philippe.
2) Updated documentation patch to add read-only for ROM usage.
3) Rebased to latest riscv-to-apply.next branch and updated tags.
Changes since v3:
1) Converted single patch to a series with a cover letter since there are
multiple patches now.
2) Added a new patch to enable pflash usage via -blockdev option.
3) Separated the documentation change into new patch and updated the
documentation to mention only -blockdev option which seems to be the
recommended way of using pflash.
Changes since v2:
1) Reverted v2 changes and used v1 approach so that pflash0 can be used
for code and pflash1 for variable store.
2) Rebased to latest riscv-to-apply.next branch.
3) Added documentation for pflash usage.
Changes since v1:
1) Simplified the fix such that it doesn't break current EDK2.
Sunil V L (3):
hw/riscv: virt: Assume M-mode FW in pflash0 only when "-bios none"
riscv/virt: Support using pflash via -blockdev option
docs/system: riscv: Add pflash usage details
docs/system/riscv/virt.rst | 31 ++++++++++++++++++++
hw/riscv/virt.c | 59 ++++++++++++++++----------------------
2 files changed, 56 insertions(+), 34 deletions(-)
--
2.34.1
next reply other threads:[~2023-06-01 5:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-01 4:59 Sunil V L [this message]
2023-06-01 4:59 ` [PATCH v7 1/3] hw/riscv: virt: Assume M-mode FW in pflash0 only when "-bios none" Sunil V L
2023-06-01 4:59 ` [PATCH v7 2/3] riscv/virt: Support using pflash via -blockdev option Sunil V L
2023-06-01 5:33 ` Alistair Francis
2023-06-01 4:59 ` [PATCH v7 3/3] docs/system: riscv: Add pflash usage details Sunil V L
2023-06-01 5:33 ` Alistair Francis
2023-06-02 2:11 ` [PATCH v7 0/3] hw/riscv/virt: pflash improvements Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230601045910.18646-1-sunilvl@ventanamicro.com \
--to=sunilvl@ventanamicro.com \
--cc=abologna@redhat.com \
--cc=alistair.francis@wdc.com \
--cc=bin.meng@windriver.com \
--cc=dbarboza@ventanamicro.com \
--cc=liweiwei@iscas.ac.cn \
--cc=palmer@dabbelt.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=zhiwei_liu@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).