From: Conor Dooley <conor@kernel.org>
To: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
Cc: qemu-devel@nongnu.org, qemu-riscv@nongnu.org,
alistair.francis@wdc.com, bmeng@tinylab.org,
liweiwei@iscas.ac.cn, zhiwei_liu@linux.alibaba.com,
palmer@rivosinc.com
Subject: Re: [PATCH for-8.2 0/2] target/riscv: add zicntr and zihpm flags
Date: Mon, 17 Jul 2023 23:33:51 +0100 [thread overview]
Message-ID: <20230717-snugly-pencil-98d62b254a74@spud> (raw)
In-Reply-To: <20230717215419.124258-1-dbarboza@ventanamicro.com>
[-- Attachment #1: Type: text/plain, Size: 1076 bytes --]
Hey,
On Mon, Jul 17, 2023 at 06:54:17PM -0300, Daniel Henrique Barboza wrote:
> Hi,
>
> I decided to include flags for both timer/counter extensions to make it
> easier for us later on when dealing with the RVA22 profile (which
> includes both).
>
> The features were already implemented by Atish Patra some time ago, but
> back then these 2 extensions weren't introduced yet. This means that,
> aside from extra stuff in riscv,isa FDT no other functional changes were
> made.
>
> Both are defaulted to 'true' since QEMU already implements both
> features, but the flag can be disabled if Zicsr isn't present or, in
> the case of zihpm, if pmu_num = 0.
Out of curiosity, since you are allowing them to be disabled, how do you
intend to communicate to a guest that zicsr or zihpm are not present?
> This means that,
> aside from extra stuff in riscv,isa FDT no other functional changes were
> made.
This is barely a "functional" change either, as the presence of these
extensions has to be assumed, whether they appear in riscv,isa or not :/
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-07-17 22:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-17 21:54 [PATCH for-8.2 0/2] target/riscv: add zicntr and zihpm flags Daniel Henrique Barboza
2023-07-17 21:54 ` [PATCH for-8.2 1/2] target/riscv/cpu.c: add zicntr extension flag Daniel Henrique Barboza
2023-07-24 1:56 ` Alistair Francis
2023-07-17 21:54 ` [PATCH for-8.2 2/2] target/riscv/cpu.c: add zihpm " Daniel Henrique Barboza
2023-07-24 2:00 ` Alistair Francis
2023-07-17 22:33 ` Conor Dooley [this message]
2023-07-17 23:11 ` [PATCH for-8.2 0/2] target/riscv: add zicntr and zihpm flags Daniel Henrique Barboza
2023-07-18 8:23 ` Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230717-snugly-pencil-98d62b254a74@spud \
--to=conor@kernel.org \
--cc=alistair.francis@wdc.com \
--cc=bmeng@tinylab.org \
--cc=dbarboza@ventanamicro.com \
--cc=liweiwei@iscas.ac.cn \
--cc=palmer@rivosinc.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=zhiwei_liu@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).