From: Robert Hoo <robert.hu@linux.intel.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
qemu-devel@nongnu.org, laurent@vivier.eu, philmd@redhat.com,
berrange@redhat.com
Cc: robert.hu@intel.com
Subject: Re: [PATCH 2/2] util: add util function buffer_zero_avx512()
Date: Thu, 13 Feb 2020 19:58:16 +0800 [thread overview]
Message-ID: <20bacabb27179111fdd517593e7ae44729aa3118.camel@linux.intel.com> (raw)
In-Reply-To: <dfc22e0f-79db-25d7-ccd8-26db1353c3b6@redhat.com>
On Thu, 2020-02-13 at 11:30 +0100, Paolo Bonzini wrote:
> On 13/02/20 08:52, Robert Hoo wrote:
> > +
> > +}
> > +#pragma GCC pop_options
> > +#endif
> > +
> > +
> > /* Note that for test_buffer_is_zero_next_accel, the most
> > preferred
> > * ISA must have the least significant bit.
> > */
> > -#define CACHE_AVX2 1
> > -#define CACHE_SSE4 2
> > -#define CACHE_SSE2 4
> > +#define CACHE_AVX512F 1
> > +#define CACHE_AVX2 2
> > +#define CACHE_SSE4 4
> > +#define CACHE_SSE2 6
>
> This should be 8, not 6.
>
> Paolo
Thanks Paolo, going to fix it in v2.
>
> >
> > /* Make sure that these variables are appropriately initialized
> > when
> > * SSE2 is enabled on the compiler command-line, but the compiler
> > is
> > @@ -226,6 +268,11 @@ static void init_accel(unsigned cache)
> > fn = buffer_zero_avx2;
> > }
> > #endif
> > +#ifdef CONFIG_AVX512F_OPT
> > + if (cache & CACHE_AVX512F) {
> > + fn = buffer_zero_avx512;
> > + }
> > +#endif
> > buffer_accel = fn;
> > }
> >
> > @@ -255,6 +302,9 @@ static void __attribute__((constructor))
> > init_cpuid_cache(void)
> > if ((bv & 6) == 6 && (b & bit_AVX2)) {
> > cache |= CACHE_AVX2;
> > }
> > + if ((bv & 6) == 6 && (b & bit_AVX512F)) {
> > + cache |= CACHE_AVX512F;
> > + }
> > }
>
>
next prev parent reply other threads:[~2020-02-13 11:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-13 7:52 [PATCH 0/2] Add AVX512F optimization option and buffer_zero_avx512() Robert Hoo
2020-02-13 7:52 ` [PATCH 1/2] configure: add configure option avx512f_opt Robert Hoo
2020-02-13 7:52 ` [PATCH 2/2] util: add util function buffer_zero_avx512() Robert Hoo
2020-02-13 10:30 ` Paolo Bonzini
2020-02-13 11:58 ` Robert Hoo [this message]
2020-02-13 18:20 ` Richard Henderson
2020-02-24 7:07 ` Robert Hoo
2020-02-24 16:13 ` Richard Henderson
2020-02-25 7:34 ` Robert Hoo
2020-02-25 15:29 ` Richard Henderson
2020-02-13 8:40 ` [PATCH 0/2] Add AVX512F optimization option and buffer_zero_avx512() no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20bacabb27179111fdd517593e7ae44729aa3118.camel@linux.intel.com \
--to=robert.hu@linux.intel.com \
--cc=berrange@redhat.com \
--cc=laurent@vivier.eu \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=robert.hu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).