From: "Cédric Le Goater" <clg@kaod.org>
To: David Gibson <david@gibson.dropbear.id.au>,
Joel Stanley <joel@jms.id.au>
Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] ppc/pnv: update skiboot to v6.4
Date: Thu, 18 Jul 2019 15:03:09 +0200 [thread overview]
Message-ID: <215c832d-779c-1597-02af-3a3a52e19f01@kaod.org> (raw)
In-Reply-To: <20190718061628.GM8468@umbus.fritz.box>
On 18/07/2019 08:16, David Gibson wrote:
> On Thu, Jul 18, 2019 at 03:12:17PM +0930, Joel Stanley wrote:
>> Currently we fail to boot a qemu powernv machine with a Power9
>> processor:
>>
>> PLAT: Detected generic platform
>> PLAT: Detected BMC platform generic
>> CPU: All 1 processors called in...
>> CHIPTOD: Unknown TOD type !
>> CHIPTOD: Failed ChipTOD detection !
>> Aborting!
>>
>> With v6.4 we can boot both a Power8 and Power9 powernv machine.
>>
>> Built from submodule with powerpc64le-linux-gnu-gcc (Debian 8.3.0-2).
>>
>> Signed-off-by: Joel Stanley <joel@jms.id.au>
> Applied to ppc-for-4.2, thanks.
>
> If you could add both POWER8 and POWER9 smoke tests to
> boot-serial-test that would be even better.
There is one for POWER8 and adding an extra for POWER9 results
in a test conflict. So I came up with the patch below. Would that
be OK ?
C.
@@ -104,6 +104,7 @@ static testdef_t tests[] = {
"-machine cap-cfpc=broken,cap-sbbc=broken,cap-ibs=broken",
"Open Firmware" },
{ "ppc64", "powernv", "-cpu POWER8", "OPAL" },
+ { "ppc64", "powernv", "-cpu POWER9", "OPAL" },
{ "ppc64", "sam460ex", "-device e1000", "8086 100e" },
{ "i386", "isapc", "-cpu qemu32 -device sga", "SGABIOS" },
{ "i386", "pc", "-device sga", "SGABIOS" },
@@ -222,6 +223,17 @@ static void test_machine(const void *dat
close(ser_fd);
}
+static char* build_testname(testdef_t *t)
+{
+ char suffix[2] = "";
+
+ if (!strcmp(t->machine, "powernv")) {
+ sscanf(t->extra, "-cpu POWER%1s", suffix);
+ }
+
+ return g_strdup_printf("boot-serial/%s%s", t->machine, suffix);
+}
+
int main(int argc, char *argv[])
{
const char *arch = qtest_get_arch();
@@ -231,7 +243,7 @@ int main(int argc, char *argv[])
for (i = 0; tests[i].arch != NULL; i++) {
if (strcmp(arch, tests[i].arch) == 0) {
- char *name = g_strdup_printf("boot-serial/%s", tests[i].machine);
+ char *name = build_testname(&tests[i]);
qtest_add_data_func(name, &tests[i], test_machine);
g_free(name);
}
next parent reply other threads:[~2019-07-18 13:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190718054218.9581-1-joel@jms.id.au>
[not found] ` <20190718061628.GM8468@umbus.fritz.box>
2019-07-18 13:03 ` Cédric Le Goater [this message]
2019-07-22 8:32 ` [Qemu-devel] [PATCH] ppc/pnv: update skiboot to v6.4 David Gibson
2019-07-22 18:24 ` Cédric Le Goater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=215c832d-779c-1597-02af-3a3a52e19f01@kaod.org \
--to=clg@kaod.org \
--cc=david@gibson.dropbear.id.au \
--cc=joel@jms.id.au \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).