qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: Max Reitz <mreitz@redhat.com>,
	"qemu-block@nongnu.org" <qemu-block@nongnu.org>
Cc: "kwolf@redhat.com" <kwolf@redhat.com>,
	Denis Lunev <den@virtuozzo.com>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	"armbru@redhat.com" <armbru@redhat.com>,
	"stefanha@redhat.com" <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v4 0/5] qcow2: async handling of fragmented io
Date: Fri, 13 Sep 2019 09:11:41 +0000	[thread overview]
Message-ID: <26cd3042-0d58-4fc4-4380-5328d3d114a0@virtuozzo.com> (raw)
In-Reply-To: <11e54b5c-eafd-411e-aadf-5b9fa4d8dc4c@redhat.com>

13.09.2019 11:58, Max Reitz wrote:
> On 16.08.19 17:30, Vladimir Sementsov-Ogievskiy wrote:
>> Hi all!
>>
>> Here is an asynchronous scheme for handling fragmented qcow2
>> reads and writes. Both qcow2 read and write functions loops through
>> sequential portions of data. The series aim it to parallelize these
>> loops iterations.
>> It improves performance for fragmented qcow2 images, I've tested it
>> as described below.
> 
> Thanks, I’ve changed two things:
> - Replaced assert((x & (BDRV_SECTOR_SIZE - 1)) == 0) by
>    assert(QEMU_IS_ALIGNED(x, BDRV_SECTOR_SIZE)) in patch 3 (conflict with
>    “block: Use QEMU_IS_ALIGNED”), and
> - Replaced the remaining instance of “qcow2_co_do_pwritev()” by
>    “qcow2_co_pwritev_task()” in a comment in patch 4
> 
> and applied the series to my block branch:
> 
> https://git.xanclic.moe/XanClic/qemu/commits/branch/block
> 
> Max
> 

Thank you!!!

-- 
Best regards,
Vladimir

  reply	other threads:[~2019-09-13  9:12 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-16 15:30 [Qemu-devel] [PATCH v4 0/5] qcow2: async handling of fragmented io Vladimir Sementsov-Ogievskiy
2019-08-16 15:30 ` [Qemu-devel] [PATCH v4 1/5] tests/qemu-iotests: Fix qemu-io related output in 026.out.nocache Vladimir Sementsov-Ogievskiy
2019-09-09 21:58   ` [Qemu-devel] [Qemu-block] " John Snow
2019-08-16 15:30 ` [Qemu-devel] [PATCH v4 2/5] block: introduce aio task pool Vladimir Sementsov-Ogievskiy
2019-08-16 15:30 ` [Qemu-devel] [PATCH v4 3/5] block/qcow2: refactor qcow2_co_preadv_part Vladimir Sementsov-Ogievskiy
2019-09-13 10:01   ` Kevin Wolf
2019-09-13 10:53     ` Vladimir Sementsov-Ogievskiy
2019-09-13 11:06       ` Max Reitz
2019-09-13 11:34         ` Kevin Wolf
2019-09-13 11:55           ` Max Reitz
2019-08-16 15:30 ` [Qemu-devel] [PATCH v4 4/5] block/qcow2: refactor qcow2_co_pwritev_part Vladimir Sementsov-Ogievskiy
2019-08-16 15:30 ` [Qemu-devel] [PATCH v4 5/5] block/qcow2: introduce parallel subrequest handling in read and write Vladimir Sementsov-Ogievskiy
2019-09-03 12:16 ` [Qemu-devel] [PATCH v4 0/5] qcow2: async handling of fragmented io Vladimir Sementsov-Ogievskiy
2019-09-13  8:58 ` Max Reitz
2019-09-13  9:11   ` Vladimir Sementsov-Ogievskiy [this message]
2019-09-16 13:26   ` Max Reitz
2019-09-16 15:29     ` Vladimir Sementsov-Ogievskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=26cd3042-0d58-4fc4-4380-5328d3d114a0@virtuozzo.com \
    --to=vsementsov@virtuozzo.com \
    --cc=armbru@redhat.com \
    --cc=den@virtuozzo.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).