From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: eesposit@redhat.com, qemu-block@nongnu.org, kwolf@redhat.com,
mreitz@redhat.com
Subject: Re: [PATCH 4/4] qemu-iotests: fix case of SOCK_DIR already in the environment
Date: Tue, 23 Mar 2021 19:45:16 +0300 [thread overview]
Message-ID: <2ca263ae-5774-2bf1-aa9b-251db97ffaf1@virtuozzo.com> (raw)
In-Reply-To: <20210323130614.146399-5-pbonzini@redhat.com>
23.03.2021 16:06, Paolo Bonzini wrote:
> Due to a typo, in this case the SOCK_DIR was not being created.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> tests/qemu-iotests/testenv.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/qemu-iotests/testenv.py b/tests/qemu-iotests/testenv.py
> index 6767eeeb25..169268f61a 100644
> --- a/tests/qemu-iotests/testenv.py
> +++ b/tests/qemu-iotests/testenv.py
> @@ -120,7 +120,7 @@ def init_directories(self) -> None:
> try:
> self.sock_dir = os.environ['SOCK_DIR']
> self.tmp_sock_dir = False
> - Path(self.test_dir).mkdir(parents=True, exist_ok=True)
> + Path(self.sock_dir).mkdir(parents=True, exist_ok=True)
> except KeyError:
> self.sock_dir = tempfile.mkdtemp()
> self.tmp_sock_dir = True
>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
--
Best regards,
Vladimir
prev parent reply other threads:[~2021-03-23 17:48 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-23 13:06 [PATCH 0/4] qemu-iotests: quality of life improvements Paolo Bonzini
2021-03-23 13:06 ` [PATCH 1/4] qemu-iotests: allow passing unittest.main arguments to the test scripts Paolo Bonzini
2021-03-23 14:34 ` Vladimir Sementsov-Ogievskiy
2021-03-23 15:29 ` Paolo Bonzini
2021-03-23 16:04 ` Vladimir Sementsov-Ogievskiy
2021-03-23 16:56 ` Vladimir Sementsov-Ogievskiy
2021-03-23 17:04 ` Paolo Bonzini
2021-03-23 17:27 ` Vladimir Sementsov-Ogievskiy
2021-03-23 17:35 ` Paolo Bonzini
2021-03-23 13:06 ` [PATCH 2/4] qemu-iotests: move command line and environment handling from TestRunner to TestEnv Paolo Bonzini
2021-03-23 16:22 ` Vladimir Sementsov-Ogievskiy
2021-03-23 13:06 ` [PATCH 3/4] qemu-iotests: let "check" spawn an arbitrary test command Paolo Bonzini
2021-03-23 16:43 ` Vladimir Sementsov-Ogievskiy
2021-03-23 17:00 ` Paolo Bonzini
2021-03-23 17:11 ` Vladimir Sementsov-Ogievskiy
2021-03-23 17:22 ` Paolo Bonzini
2021-03-23 17:39 ` Vladimir Sementsov-Ogievskiy
2021-03-23 13:06 ` [PATCH 4/4] qemu-iotests: fix case of SOCK_DIR already in the environment Paolo Bonzini
2021-03-23 16:45 ` Vladimir Sementsov-Ogievskiy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ca263ae-5774-2bf1-aa9b-251db97ffaf1@virtuozzo.com \
--to=vsementsov@virtuozzo.com \
--cc=eesposit@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).