From: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
To: Alexander Bulekov <alxndr@bu.edu>
Cc: Fam Zheng <fam@euphon.net>, Laurent Vivier <lvivier@redhat.com>,
Thomas Huth <thuth@redhat.com>,
qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH] tests/qtest: add one more test for the am53c974
Date: Wed, 7 Apr 2021 16:11:20 +0100 [thread overview]
Message-ID: <30d2b8d8-2861-509b-16be-34767b4cbe4d@ilande.co.uk> (raw)
In-Reply-To: <20210407144930.3332oqbwzidrou6z@mozz.bu.edu>
On 07/04/2021 15:49, Alexander Bulekov wrote:
> Hi Mark,
> I guess there must have been something timing-sensitive in the
> reproducer... Too bad it didn't work.
Yeah, it would have been nice to have something that could be triggered directly by a
test but never mind.
>> diff --git a/hw/scsi/esp.c b/hw/scsi/esp.c
>> index 0037197bdb..b668acef82 100644
>> --- a/hw/scsi/esp.c
>> +++ b/hw/scsi/esp.c
>> @@ -357,6 +357,7 @@ static void handle_satn(ESPState *s)
>> cmdlen = get_cmd(s, ESP_CMDFIFO_SZ);
>> if (cmdlen > 0) {
>> s->cmdfifo_cdb_offset = 1;
>> + s->do_cmd = 0;
>> do_cmd(s);
>> } else if (cmdlen == 0) {
>> s->do_cmd = 1;
>> @@ -390,6 +391,7 @@ static void handle_s_without_atn(ESPState *s)
>> cmdlen = get_cmd(s, ESP_CMDFIFO_SZ);
>> if (cmdlen > 0) {
>> s->cmdfifo_cdb_offset = 0;
>> + s->do_cmd = 0;
>> do_busid_cmd(s, 0);
>> } else if (cmdlen == 0) {
>> s->do_cmd = 1;
>>
>
> With this applied, I don't see either of those asserts anymore.
> Thank you!
> -Alex
Awesome! I'll include this in v4. BTW does this now mean that the am53c974 survives a
run through your fuzzer corpus?
ATB,
Mark.
prev parent reply other threads:[~2021-04-07 15:12 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-01 7:49 [PATCH v3 00/11] esp: fix asserts/segfaults discovered by fuzzer Mark Cave-Ayland
2021-04-01 7:49 ` [PATCH v3 01/11] esp: always check current_req is not NULL before use in DMA callbacks Mark Cave-Ayland
2021-04-01 7:49 ` [PATCH v3 02/11] esp: rework write_response() to avoid using the FIFO for DMA transactions Mark Cave-Ayland
2021-04-01 8:26 ` Philippe Mathieu-Daudé
2021-04-01 7:49 ` [PATCH v3 03/11] esp: consolidate esp_cmdfifo_push() into esp_fifo_push() Mark Cave-Ayland
2021-04-01 8:15 ` Philippe Mathieu-Daudé
2021-04-01 8:50 ` Mark Cave-Ayland
2021-04-01 9:16 ` Philippe Mathieu-Daudé
2021-04-01 7:49 ` [PATCH v3 04/11] esp: consolidate esp_cmdfifo_pop() into esp_fifo_pop() Mark Cave-Ayland
2021-04-01 8:15 ` Philippe Mathieu-Daudé
2021-04-01 7:49 ` [PATCH v3 05/11] esp: introduce esp_fifo_pop_buf() and use it instead of fifo8_pop_buf() Mark Cave-Ayland
2021-04-01 9:34 ` Philippe Mathieu-Daudé
2021-04-01 10:51 ` Mark Cave-Ayland
2021-04-01 18:05 ` Philippe Mathieu-Daudé
2021-04-01 7:49 ` [PATCH v3 06/11] esp: ensure cmdfifo is not empty and current_dev is non-NULL Mark Cave-Ayland
2021-04-01 8:17 ` Philippe Mathieu-Daudé
2021-04-01 7:49 ` [PATCH v3 07/11] esp: don't underflow cmdfifo in do_cmd() Mark Cave-Ayland
2021-04-01 8:19 ` Philippe Mathieu-Daudé
2021-04-01 8:51 ` Mark Cave-Ayland
2021-04-01 7:49 ` [PATCH v3 08/11] esp: don't overflow cmdfifo in get_cmd() Mark Cave-Ayland
2021-04-01 8:19 ` Philippe Mathieu-Daudé
2021-04-01 8:56 ` Mark Cave-Ayland
2021-04-01 7:49 ` [PATCH v3 09/11] esp: don't overflow cmdfifo if TC is larger than the cmdfifo size Mark Cave-Ayland
2021-04-01 7:49 ` [PATCH v3 10/11] esp: don't reset async_len directly in esp_select() if cancelling request Mark Cave-Ayland
2021-04-01 7:49 ` [PATCH v3 11/11] tests/qtest: add tests for am53c974 device Mark Cave-Ayland
2021-04-01 16:55 ` Alexander Bulekov
2021-04-02 7:29 ` Mark Cave-Ayland
2021-04-01 17:00 ` [PATCH v3 00/11] esp: fix asserts/segfaults discovered by fuzzer Alexander Bulekov
2021-04-02 7:35 ` Mark Cave-Ayland
2021-04-02 16:20 ` [PATCH] tests/qtest: add one more test for the am53c974 Alexander Bulekov
2021-04-03 14:38 ` Mark Cave-Ayland
2021-04-07 12:08 ` Mark Cave-Ayland
2021-04-07 13:04 ` Mark Cave-Ayland
2021-04-07 14:49 ` Alexander Bulekov
2021-04-07 15:11 ` Mark Cave-Ayland [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30d2b8d8-2861-509b-16be-34767b4cbe4d@ilande.co.uk \
--to=mark.cave-ayland@ilande.co.uk \
--cc=alxndr@bu.edu \
--cc=fam@euphon.net \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).