Re: [PATCH v4 23/23] simplebench: add bench-backup.py

[Max Reitz <mreitz@redhat.com>]

On 16.01.21 22:47, Vladimir Sementsov-Ogievskiy wrote:
> Add script to benchmark new backup architecture.
> 
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
>   scripts/simplebench/bench-backup.py | 167 ++++++++++++++++++++++++++++
>   1 file changed, 167 insertions(+)
>   create mode 100755 scripts/simplebench/bench-backup.py
> 
> diff --git a/scripts/simplebench/bench-backup.py b/scripts/simplebench/bench-backup.py
> new file mode 100755
> index 0000000000..2cf7a852e0
> --- /dev/null
> +++ b/scripts/simplebench/bench-backup.py
> @@ -0,0 +1,167 @@
> +#!/usr/bin/env python3
> +#
> +# Bench backup block-job
> +#
> +# Copyright (c) 2020 Virtuozzo International GmbH.
> +#
> +# This program is free software; you can redistribute it and/or modify
> +# it under the terms of the GNU General Public License as published by
> +# the Free Software Foundation; either version 2 of the License, or
> +# (at your option) any later version.
> +#
> +# This program is distributed in the hope that it will be useful,
> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +# GNU General Public License for more details.
> +#
> +# You should have received a copy of the GNU General Public License
> +# along with this program.  If not, see <http://www.gnu.org/licenses/>.
> +#
> +
> +import argparse
> +import json
> +
> +import simplebench
> +from results_to_text import results_to_text
> +from bench_block_job import bench_block_copy, drv_file, drv_nbd
> +
> +
> +def bench_func(env, case):
> +    """ Handle one "cell" of benchmarking table. """
> +    cmd_options = env['cmd-options'] if 'cmd-options' in env else {}
> +    return bench_block_copy(env['qemu-binary'], env['cmd'],
> +                            cmd_options,
> +                            case['source'], case['target'])
> +
> +
> +def bench(args):
> +    test_cases = []
> +
> +    sources = {}
> +    targets = {}
> +    for d in args.dir:
> +        label, path = d.split(':')  # paths with colon not unsupported

s/ un//, I think.

Adding these comments (and the assert below) instead of using splitn() 
is fine for me.

Max