From: Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>
To: Max Reitz <mreitz@redhat.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"qemu-block@nongnu.org" <qemu-block@nongnu.org>
Cc: "kwolf@redhat.com" <kwolf@redhat.com>,
"fam@euphon.net" <fam@euphon.net>,
Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
"berto@igalia.com" <berto@igalia.com>,
Denis Lunev <den@virtuozzo.com>,
"wencongyang2@huawei.com" <wencongyang2@huawei.com>,
"xiechanglong.d@gmail.com" <xiechanglong.d@gmail.com>,
"stefanha@redhat.com" <stefanha@redhat.com>,
"jsnow@redhat.com" <jsnow@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v7 0/3] block/stream: get rid of the base
Date: Tue, 25 Jun 2019 14:40:19 +0000 [thread overview]
Message-ID: <3362e8ef-d698-e860-9830-45a3f924ef48@virtuozzo.com> (raw)
In-Reply-To: <87a5ec62-6274-77c6-60a3-b4ad7b4ec822@redhat.com>
On 19/06/2019 22:29, Max Reitz wrote:
> On 29.05.19 19:56, Andrey Shinkevich wrote:
>> This series introduces a bottom intermediate node that eliminates the
>> dependency on the base that may change while stream job is running.
>> It happens when stream/commit parallel jobs are running on the same
>> backing chain. The base node of the stream job may be a top node of
>> the parallel commit job and can change before the stream job is
>> completed. We avoid that dependency by introducing the bottom node.
>>
>> v7: [resend by Andrey]
>> 01: assert(intermediate) was inserted before the call to
>> bdrv_is_allocated() in the intermediate node loop of the
>> bdrv_is_allocated_above() as suggested by Max.
>> 02: The change of the intermediate node loop in the stream_start() was
>> rolled back to its original design and the reassignment of the base
>> node pointer was added as Vladimir and Max suggested. The relevant
>> comment was amended.
>>
>> v6: [resend by Vladimir]
>> 01: improve comment in block/io.c, suggested by Alberto
>>
>> v5: [resend by Vladimir]
>> 01: use comment wording in block/io.c suggested by Alberto
>>
>> v4:
>> trace_stream_start reverted to the base.
>> bdrv_is_allocated_above_inclusive() deleted and the new parameter
>> 'bool include_base' was added to the bdrv_is_allocated_above().
>>
>> Andrey Shinkevich (3):
>> block: include base when checking image chain for block allocation
>> block/stream: refactor stream_run: drop goto
>> block/stream: introduce a bottom node
>>
>> block/commit.c | 2 +-
>> block/io.c | 21 +++++++++++++------
>> block/mirror.c | 2 +-
>> block/replication.c | 2 +-
>> block/stream.c | 56 ++++++++++++++++++++++++--------------------------
>> include/block/block.h | 3 ++-
>> tests/qemu-iotests/245 | 4 ++--
>> 7 files changed, 49 insertions(+), 41 deletions(-)
>
> Reviewed-by: Max Reitz <mreitz@redhat.com>
>
> Just needs some simple changes to patch 1 to rebase it on 863cc78f1b3
> and c8bb23cbdbe.
>
> Max
>
Please let us know who would take this series for pull request?
Andrey
--
With the best regards,
Andrey Shinkevich
next prev parent reply other threads:[~2019-06-25 14:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-29 17:56 [Qemu-devel] [PATCH v7 0/3] block/stream: get rid of the base Andrey Shinkevich
2019-05-29 17:56 ` [Qemu-devel] [PATCH v7 1/3] block: include base when checking image chain for block allocation Andrey Shinkevich
2019-06-19 19:27 ` Max Reitz
2019-06-21 8:34 ` Vladimir Sementsov-Ogievskiy
2019-06-24 9:31 ` Andrey Shinkevich
2019-05-29 17:56 ` [Qemu-devel] [PATCH v7 2/3] block/stream: refactor stream_run: drop goto Andrey Shinkevich
2019-05-29 17:56 ` [Qemu-devel] [PATCH v7 3/3] block/stream: introduce a bottom node Andrey Shinkevich
2019-06-19 19:29 ` [Qemu-devel] [PATCH v7 0/3] block/stream: get rid of the base Max Reitz
2019-06-25 14:40 ` Andrey Shinkevich [this message]
2019-06-25 15:03 ` Max Reitz
2019-06-25 15:07 ` Andrey Shinkevich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3362e8ef-d698-e860-9830-45a3f924ef48@virtuozzo.com \
--to=andrey.shinkevich@virtuozzo.com \
--cc=berto@igalia.com \
--cc=den@virtuozzo.com \
--cc=fam@euphon.net \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=vsementsov@virtuozzo.com \
--cc=wencongyang2@huawei.com \
--cc=xiechanglong.d@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).