From: Christian Borntraeger <borntraeger@de.ibm.com>
To: Cornelia Huck <cohuck@redhat.com>, Halil Pasic <pasic@linux.ibm.com>
Cc: Thomas Huth <thuth@redhat.com>,
Matthew Rosato <mjrosato@linux.ibm.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
David Hildenbrand <david@redhat.com>,
qemu-devel@nongnu.org, qemu-s390x@nongnu.org,
Richard Henderson <rth@twiddle.net>
Subject: Re: [PATCH 0/2] two atomic_cmpxchg() related fixes
Date: Wed, 1 Jul 2020 14:06:11 +0200 [thread overview]
Message-ID: <3674a552-fdf3-ffad-a729-efcb730adf1c@de.ibm.com> (raw)
In-Reply-To: <20200701140106.004a3da2.cohuck@redhat.com>
On 01.07.20 14:01, Cornelia Huck wrote:
> On Tue, 16 Jun 2020 06:50:33 +0200
> Halil Pasic <pasic@linux.ibm.com> wrote:
>
>> The story short: compiler can generate code that does two
>> distinct fetches of *ind_addr for old and _old. If that happens we can
>> not figure out if we had the desired xchg or not.
>>
>> Halil Pasic (2):
>> virtio-ccw: fix virtio_set_ind_atomic
>> s390x/pci: fix set_ind_atomic
>>
>> hw/s390x/s390-pci-bus.c | 16 +++++++++-------
>> hw/s390x/virtio-ccw.c | 18 ++++++++++--------
>> 2 files changed, 19 insertions(+), 15 deletions(-)
>>
>>
>> base-commit: 7d3660e79830a069f1848bb4fa1cdf8f666424fb
>
> Have we managed to reach any kind of agreement on this? (A v2?)
>
> We can still get in fixes post-softfreeze, of course.
Unless Halil has a v2 ready,
I think the current patch is fine as is as a fix. I would suggest
to go with that and we can then do more beautification later when
necessary.
next prev parent reply other threads:[~2020-07-01 12:07 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-16 4:50 [PATCH 0/2] two atomic_cmpxchg() related fixes Halil Pasic
2020-06-16 4:50 ` [PATCH 1/2] virtio-ccw: fix virtio_set_ind_atomic Halil Pasic
2020-06-16 5:58 ` Christian Borntraeger
2020-06-16 6:33 ` Cornelia Huck
2020-06-16 6:45 ` Christian Borntraeger
2020-06-19 7:14 ` Cornelia Huck
2020-06-17 23:56 ` Halil Pasic
2020-06-19 7:33 ` David Hildenbrand
2020-06-19 8:17 ` Halil Pasic
2020-06-16 9:31 ` Halil Pasic
2020-07-01 13:13 ` Christian Borntraeger
2020-07-04 18:34 ` Michael S. Tsirkin
2020-07-06 5:44 ` Christian Borntraeger
2020-07-06 11:19 ` Halil Pasic
2020-06-16 4:50 ` [PATCH 2/2] s390x/pci: fix set_ind_atomic Halil Pasic
2020-07-01 13:14 ` Christian Borntraeger
2020-07-01 12:01 ` [PATCH 0/2] two atomic_cmpxchg() related fixes Cornelia Huck
2020-07-01 12:06 ` Christian Borntraeger [this message]
2020-07-01 13:10 ` Cornelia Huck
2020-07-03 13:37 ` Halil Pasic
2020-07-03 14:03 ` Cornelia Huck
2020-07-02 11:18 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3674a552-fdf3-ffad-a729-efcb730adf1c@de.ibm.com \
--to=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=mjrosato@linux.ibm.com \
--cc=mst@redhat.com \
--cc=pasic@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=rth@twiddle.net \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).