From: Paul Clarke <pc@us.ibm.com>
To: qemu-devel@nongnu.org
Cc: qemu-ppc@nongnu.org, richard.henderson@linaro.org,
david@gibson.dropbear.id.au
Subject: Re: [Qemu-devel] [PATCH v3] ppc: Add support for 'mffsl' instruction
Date: Wed, 14 Aug 2019 11:34:13 -0500 [thread overview]
Message-ID: <3ff4c0cd-b757-55e3-c675-cbfd74a7f76e@us.ibm.com> (raw)
In-Reply-To: <156580023314.3056.6268901484469396279@5dec9699b7de>
Should these 'checkpatch' ERRORs be addressed, even if it will diverge the code style from the existing, surrounding code?
On 8/14/19 11:30 AM, no-reply@patchew.org wrote:
> This series seems to have some coding style problems. See output below for
> more information:
> === OUTPUT BEGIN ===
> ERROR: code indent should never use tabs
> #54: FILE: disas/ppc.c:5004:
> +{ "mffsl", XRA(63,583,12), XRARB_MASK,^IPOWER9,^I{ FRT } },$
>
> ERROR: space required after that ',' (ctx:VxV)
> #54: FILE: disas/ppc.c:5004:
> +{ "mffsl", XRA(63,583,12), XRARB_MASK, POWER9, { FRT } },
> ^
>
> ERROR: space required after that ',' (ctx:VxV)
> #54: FILE: disas/ppc.c:5004:
> +{ "mffsl", XRA(63,583,12), XRARB_MASK, POWER9, { FRT } },
> ^
>
> ERROR: braces {} are necessary for all arms of this statement
> #148: FILE: target/ppc/translate/fp-impl.inc.c:625:
> + if (unlikely(!(ctx->insns_flags2 & PPC2_ISA300)))
> [...]
>
> total: 4 errors, 0 warnings, 115 lines checked
>
> Commit c51c0f894525 (ppc: Add support for 'mffsl' instruction) has style problems, please review. If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
> === OUTPUT END ===
PC
next prev parent reply other threads:[~2019-08-14 16:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-14 16:14 [Qemu-devel] [PATCH v3] ppc: Add support for 'mffsl' instruction Paul A. Clarke
2019-08-14 16:30 ` no-reply
2019-08-14 16:34 ` Paul Clarke [this message]
2019-08-14 23:57 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ff4c0cd-b757-55e3-c675-cbfd74a7f76e@us.ibm.com \
--to=pc@us.ibm.com \
--cc=david@gibson.dropbear.id.au \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).