From: Paolo Bonzini <pbonzini@redhat.com>
To: Sunil Muthuswamy <sunilmut@microsoft.com>,
Richard Henderson <rth@twiddle.net>,
Eduardo Habkost <ehabkost@redhat.com>,
Stefan Weil <sw@weilnetz.de>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"Justin Terry \(VM\)" <juterry@microsoft.com>
Subject: Re: [PATCH] WHPX: refactor load library
Date: Wed, 13 Nov 2019 15:59:53 +0100 [thread overview]
Message-ID: <4d20ec63-7eae-7c7f-167b-f87709adcd78@redhat.com> (raw)
In-Reply-To: <MW2PR2101MB1116386CFE4628B6767D6CDBC07B0@MW2PR2101MB1116.namprd21.prod.outlook.com>
On 08/11/19 21:31, Sunil Muthuswamy wrote:
>
> +typedef enum WHPFunctionList {
> + WINHV_PLATFORM_FNS_DEFAULT,
> + WINHV_EMULATION_FNS_DEFAULT,
> +} WHPFunctionList;
>
What does "default" stand for? I assume you have more changes to this
function in the future.
> + * Load the functions from the given library, using the given handle. If a
> + * handle is provided, it is used, otherwise the library is opened. The
> + * handle will be updated on return with the opened one.
> + */
> +static bool load_whp_dipatch_fns(HMODULE *handle, WHPFunctionList function_list)
> +{
Typo, "dipatch" instead of "dispatch".
>
> + if (hLib) {
> + FreeLibrary(hWinHvEmulation);
> + }
The argument to FreeLibrary should be hLib.
Paolo
next prev parent reply other threads:[~2019-11-13 15:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-08 20:31 [PATCH] WHPX: refactor load library Sunil Muthuswamy
2019-11-12 18:42 ` Sunil Muthuswamy
2019-11-12 19:47 ` Eduardo Habkost
2019-11-13 16:35 ` Philippe Mathieu-Daudé
2019-11-13 16:49 ` Eduardo Habkost
2019-11-13 17:21 ` Sunil Muthuswamy
2019-11-13 17:12 ` Sunil Muthuswamy
2019-11-13 14:59 ` Paolo Bonzini [this message]
2019-11-13 16:59 ` Sunil Muthuswamy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d20ec63-7eae-7c7f-167b-f87709adcd78@redhat.com \
--to=pbonzini@redhat.com \
--cc=ehabkost@redhat.com \
--cc=juterry@microsoft.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=sunilmut@microsoft.com \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).