From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Michael Roth <mdroth@linux.vnet.ibm.com>, qemu-devel@nongnu.org
Cc: lersek@redhat.com, brogers@suse.com
Subject: Re: [Qemu-devel] [PATCH 0/2] Fix tarball builds of UEFI/EDK2 firmware
Date: Thu, 19 Sep 2019 15:51:57 +0200 [thread overview]
Message-ID: <4d90ff88-07ad-b456-bae4-bd635e192d02@redhat.com> (raw)
In-Reply-To: <20190912231202.12327-1-mdroth@linux.vnet.ibm.com>
On 9/13/19 1:12 AM, Michael Roth wrote:
> Bruce noticed that we cannot build `make efi` target from the v4.1.0
> tarball. This is due to a failure on the part of the make-release script
> to pull in submodules nested under other submodules, as well as
> Makefile.edk2's assumptions about being in a git tree.
Hmm I'd expect distributions interested in building EDK2, build it
properly tuned, outside of QEMU. I consider what is here as default
config useful for testing, not for production use. I might be wrong.
Meanwhile, it is true 'make efi' should not fail.
> Suggestions for more robust solutions are definitely welcome, but for
> now this series takes what seems to be the most direct approach.
This is fine:
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
I'll queue these patches in my edk2-next branch since I'm preparing a
pull request.
Thanks,
Phil.
prev parent reply other threads:[~2019-09-19 14:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-12 23:12 [Qemu-devel] [PATCH 0/2] Fix tarball builds of UEFI/EDK2 firmware Michael Roth
2019-09-12 23:12 ` [Qemu-devel] [PATCH 1/2] make-release: pull in edk2 submodules so we can build it from tarballs Michael Roth
2019-09-12 23:12 ` [Qemu-devel] [PATCH 2/2] roms/Makefile.edk2: don't pull in submodules when building from tarball Michael Roth
2019-09-13 12:33 ` Laszlo Ersek
2019-09-20 19:50 ` Philippe Mathieu-Daudé
2019-09-24 20:47 ` Laszlo Ersek
2019-09-19 13:51 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d90ff88-07ad-b456-bae4-bd635e192d02@redhat.com \
--to=philmd@redhat.com \
--cc=brogers@suse.com \
--cc=lersek@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).