From: Jason Wang <jasowang@redhat.com>
To: Mauro Matteo Cascella <mcascell@redhat.com>
Cc: Dmitry Fleytman <dmitry.fleytman@gmail.com>,
QEMU Developers <qemu-devel@nongnu.org>,
ziming zhang <ezrakiez@gmail.com>
Subject: Re: [PATCH 1/2] hw/net/net_tx_pkt: add function to check pkt->max_raw_frags
Date: Fri, 31 Jul 2020 11:33:42 +0800 [thread overview]
Message-ID: <4f6c065e-de0c-4fe3-f4aa-8e98a48d2650@redhat.com> (raw)
In-Reply-To: <CAA8xKjWoyTPEbW=xdKqtTHHn2krKssif9t6nEeWGDQLt7KmCvg@mail.gmail.com>
On 2020/7/31 上午1:05, Mauro Matteo Cascella wrote:
> On Thu, Jul 30, 2020 at 7:28 AM Jason Wang<jasowang@redhat.com> wrote:
>> On 2020/7/29 上午12:26, Mauro Matteo Cascella wrote:
>>> On Tue, Jul 28, 2020 at 6:06 AM Jason Wang<jasowang@redhat.com> wrote:
>>>> On 2020/7/28 上午1:08, Mauro Matteo Cascella wrote:
>>>>> This patch introduces a new function in hw/net/net_tx_pkt.{c,h} to check the
>>>>> current data fragment against the maximum number of data fragments.
>>>> I wonder whether it's better to do the check in
>>>> net_tx_pkt_add_raw_fragment() and fail there.
>>> Given the assertion, I assumed the caller is responsible for the
>>> check, but moving the check in net_tx_pkt_add_raw_fragment() totally
>>> makes sense to me.
>> Want to send a new version for this?
> Sure, I'll send a new version. Thank you.
>
>>>> Btw, I find net_tx_pkt_add_raw_fragment() does not unmap dma when
>>>> returning to true, is this a bug?
>>> Isn't it unmapped in net_tx_pkt_reset()?
>> Probably but see how it was used in e1000e, the net_tx_pkt_reset() is
>> only called when eop is set. Is this a bug?
> Yeah it all depends on E1000_TXD_CMD_EOP. Besides, if not set,
> e1000e_tx_pkt_send() would never be called. Honestly, I don't know if
> this is a reasonable scenario or not.
It's probably fine since anyway e1000e_core_reset() will call
net_tx_pkt_reset().
Thanks
>
>> Thanks
>>
next prev parent reply other threads:[~2020-07-31 3:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-27 17:08 [PATCH 0/2] assertion failure in net_tx_pkt_add_raw_fragment() in hw/net/net_tx_pkt.c Mauro Matteo Cascella
2020-07-27 17:08 ` [PATCH 1/2] hw/net/net_tx_pkt: add function to check pkt->max_raw_frags Mauro Matteo Cascella
2020-07-28 4:06 ` Jason Wang
2020-07-28 16:26 ` Mauro Matteo Cascella
2020-07-30 5:27 ` Jason Wang
2020-07-30 17:05 ` Mauro Matteo Cascella
2020-07-31 3:33 ` Jason Wang [this message]
2020-07-27 17:08 ` [PATCH 2/2] hw/net: check max_raw_frags in e1000e and vmxnet3 devices Mauro Matteo Cascella
2020-07-27 17:29 ` [PATCH 0/2] assertion failure in net_tx_pkt_add_raw_fragment() in hw/net/net_tx_pkt.c Alexander Bulekov
2020-07-28 16:59 ` Mauro Matteo Cascella
2020-07-29 8:48 ` Dmitry Fleytman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4f6c065e-de0c-4fe3-f4aa-8e98a48d2650@redhat.com \
--to=jasowang@redhat.com \
--cc=dmitry.fleytman@gmail.com \
--cc=ezrakiez@gmail.com \
--cc=mcascell@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).