On 12/13/19 1:06 PM, Cornelia Huck wrote: > On Thu, 5 Dec 2019 11:12:39 +0100 > Cornelia Huck wrote: > >> On Tue, 3 Dec 2019 08:28:13 -0500 >> Janosch Frank wrote: >> >>> We need to set the short psw indication bit in the reset psw, as it is >>> a short psw. >>> >>> fixes: 9629823290 ("pc-bios/s390-ccw: do a subsystem reset before running the guest") >>> Signed-off-by: Janosch Frank >>> --- >>> pc-bios/s390-ccw/jump2ipl.c | 12 +++++++----- >>> 1 file changed, 7 insertions(+), 5 deletions(-) >> >> Thanks, applied (together with a rebuild of the bios images.) > > This unfortunately breaks 'make check-qtest-s390x': > > TEST check-qtest-s390x: tests/boot-serial-test > TEST check-qtest-s390x: tests/pxe-test > ERROR - too few tests run (expected 1, got 0) > > When I revert this, the rebuild, and "s390x: Properly fetch and test > the short psw on diag308 subc 0/1" (as it exposes the bug this commit > tried to fix), everything passes again. No idea what is wrong, though :( > > For now, I've dropped the three patches mentioned above from the > s390-next branch (I plan to send a pull request later). Let's fix this > on top once we figured out whatever went wrong, no need to rush here. > > Sounds good