From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50804) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aSoAj-00075W-H4 for qemu-devel@nongnu.org; Mon, 08 Feb 2016 10:56:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aSoAf-00057M-IE for qemu-devel@nongnu.org; Mon, 08 Feb 2016 10:56:17 -0500 References: <1454690704-16233-1-git-send-email-peter.maydell@linaro.org> <1454690704-16233-5-git-send-email-peter.maydell@linaro.org> From: Sergey Fedorov Message-ID: <56B8BA93.202@gmail.com> Date: Mon, 8 Feb 2016 18:56:03 +0300 MIME-Version: 1.0 In-Reply-To: <1454690704-16233-5-git-send-email-peter.maydell@linaro.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 4/6] target-arm: Implement MDCR_EL2.TDRA traps List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , qemu-devel@nongnu.org Cc: "Edgar E. Iglesias" , qemu-arm@nongnu.org, patches@linaro.org On 05.02.2016 19:45, Peter Maydell wrote: > Implement trapping of the "debug ROM" registers, which are controlled > by MDCR_EL2.TDRA for EL2 but by the more general MDCR_EL3.TDA for EL3. > > Signed-off-by: Peter Maydell Reviewed-by: Sergey Fedorov > --- > target-arm/helper.c | 27 ++++++++++++++++++++++++--- > 1 file changed, 24 insertions(+), 3 deletions(-) > > diff --git a/target-arm/helper.c b/target-arm/helper.c > index 18e85fd..8c2adbc 100644 > --- a/target-arm/helper.c > +++ b/target-arm/helper.c > @@ -402,6 +402,24 @@ static CPAccessResult access_tdosa(CPUARMState *env, const ARMCPRegInfo *ri, > return CP_ACCESS_OK; > } > > +/* Check for traps to "debug ROM" registers, which are controlled > + * by MDCR_EL2.TDRA for EL2 but by the more general MDCR_EL3.TDA for EL3. > + */ > +static CPAccessResult access_tdra(CPUARMState *env, const ARMCPRegInfo *ri, > + bool isread) > +{ > + int el = arm_current_el(env); > + > + if (el < 2 && (env->cp15.mdcr_el2 & MDCR_TDRA) > + && !arm_is_secure_below_el3(env)) { > + return CP_ACCESS_TRAP_EL2; > + } > + if (el < 3 && (env->cp15.mdcr_el3 & MDCR_TDA)) { > + return CP_ACCESS_TRAP_EL3; > + } > + return CP_ACCESS_OK; > +} > + > static void dacr_write(CPUARMState *env, const ARMCPRegInfo *ri, uint64_t value) > { > ARMCPU *cpu = arm_env_get_cpu(env); > @@ -3774,12 +3792,15 @@ static const ARMCPRegInfo debug_cp_reginfo[] = { > * accessor. > */ > { .name = "DBGDRAR", .cp = 14, .crn = 1, .crm = 0, .opc1 = 0, .opc2 = 0, > - .access = PL0_R, .type = ARM_CP_CONST, .resetvalue = 0 }, > + .access = PL0_R, .accessfn = access_tdra, > + .type = ARM_CP_CONST, .resetvalue = 0 }, > { .name = "MDRAR_EL1", .state = ARM_CP_STATE_AA64, > .opc0 = 2, .opc1 = 0, .crn = 1, .crm = 0, .opc2 = 0, > - .access = PL1_R, .type = ARM_CP_CONST, .resetvalue = 0 }, > + .access = PL1_R, .accessfn = access_tdra, > + .type = ARM_CP_CONST, .resetvalue = 0 }, > { .name = "DBGDSAR", .cp = 14, .crn = 2, .crm = 0, .opc1 = 0, .opc2 = 0, > - .access = PL0_R, .type = ARM_CP_CONST, .resetvalue = 0 }, > + .access = PL0_R, .accessfn = access_tdra, > + .type = ARM_CP_CONST, .resetvalue = 0 }, > /* Monitor debug system control register; the 32-bit alias is DBGDSCRext. */ > { .name = "MDSCR_EL1", .state = ARM_CP_STATE_BOTH, > .cp = 14, .opc0 = 2, .opc1 = 0, .crn = 0, .crm = 2, .opc2 = 2,