Re: [Qemu-devel] [PATCH 1/2] tests/i440fx-test: Don't define ARRAY_SIZE locally

From: Eric Blake <eblake@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: Markus Armbruster <armbru@redhat.com>, patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH 1/2] tests/i440fx-test: Don't define ARRAY_SIZE locally
Date: Mon, 8 Feb 2016 13:32:01 -0700	[thread overview]
Message-ID: <56B8FB41.9020701@redhat.com> (raw)
In-Reply-To: <1454957357-22094-2-git-send-email-peter.maydell@linaro.org>

[-- Attachment #1: Type: text/plain, Size: 951 bytes --]

On 02/08/2016 11:49 AM, Peter Maydell wrote:
> Don't define ARRAY_SIZE locally; instead include osdep.h for it.
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>  tests/i440fx-test.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

Reviewed-by: Eric Blake <eblake@redhat.com>

> 
> diff --git a/tests/i440fx-test.c b/tests/i440fx-test.c
> index 7fa1709..0665caf 100644
> --- a/tests/i440fx-test.c
> +++ b/tests/i440fx-test.c
> @@ -12,6 +12,7 @@
>   * See the COPYING file in the top-level directory.
>   */
>  
> +#include "qemu/osdep.h"
>  #include <glib.h>
>  #include <string.h>
>  #include <stdio.h>
> @@ -27,8 +28,6 @@
>  
>  #define BROKEN 1
>  
> -#define ARRAY_SIZE(array) (sizeof(array) / sizeof((array)[0]))
> -
>  typedef struct TestData
>  {
>      int num_cpus;
> 

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]