From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44195) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aTvTm-0004mX-Ri for qemu-devel@nongnu.org; Thu, 11 Feb 2016 12:56:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aTvTl-0006om-Pd for qemu-devel@nongnu.org; Thu, 11 Feb 2016 12:56:34 -0500 Received: from mx1.redhat.com ([209.132.183.28]:41574) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aTvTl-0006oc-IX for qemu-devel@nongnu.org; Thu, 11 Feb 2016 12:56:33 -0500 References: <02ab9a89d11c545664eefed50144e644a3d945cc.1454927009.git.samuel.thibault@ens-lyon.org> <56BAF7DC.1020904@redhat.com> <20160210092017.GB3423@var.bordeaux.inria.fr> From: Eric Blake Message-ID: <56BCCB4E.3040706@redhat.com> Date: Thu, 11 Feb 2016 10:56:30 -0700 MIME-Version: 1.0 In-Reply-To: <20160210092017.GB3423@var.bordeaux.inria.fr> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="DGGME645iiF1d6Cd1q5UJpQwGWdPioMQp" Subject: Re: [Qemu-devel] [PATCHv7 6/9] slirp: Reindent after refactoring List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Samuel Thibault , Thomas Huth Cc: zhanghailiang , Li Zhijian , Stefan Hajnoczi , Jason Wang , qemu-devel@nongnu.org, Vasiliy Tolstov , Dave Gilbert , Gonglei , Jan Kiszka , Huangpeng , Guillaume Subiron This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --DGGME645iiF1d6Cd1q5UJpQwGWdPioMQp Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 02/10/2016 02:20 AM, Samuel Thibault wrote: > Thomas Huth, on Wed 10 Feb 2016 09:42:04 +0100, wrote: >> On 08.02.2016 11:28, Samuel Thibault wrote: >>> Signed-off-by: Guillaume Subiron >>> Signed-off-by: Samuel Thibault >>> --- >>> slirp/tcp_input.c | 99 +++++++++++++++++++++++++++-----------------= ---------- >>> slirp/tcp_output.c | 29 ++++++++-------- >>> slirp/tcp_subr.c | 50 +++++++++++++-------------- >>> 3 files changed, 89 insertions(+), 89 deletions(-) >> >> Not sure, it's just an idea, but maybe it would even make sense to >> re-indent the whole files in the QEMU coding style now? I mean, indent= >> with 4 spaces instead of tabs? >=20 > I'm fine with doing it. Maintainers, what do you think? If done as part of the series, it's probably okay to do it as a pre-requisite patch. Don't mix it in with actual code changes, and we don't do whole-sale reindenting except as part of a larger series (because 'git blame' will point to whoever did the reindenting instead of the original code, which doesn't make sense when reindenting is done in isolation). --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --DGGME645iiF1d6Cd1q5UJpQwGWdPioMQp Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWvMtOAAoJEKeha0olJ0Nq+5MH/0uzoTlgEyBbZe3N3Aw8+9S9 C5Jc+janrF6WPm0/SUPbVHFf5XyeGWY+/m5EEamIiqDaSUTCxQ5zwCGJRNBbNox4 9QqEhyaild9bZlcm4+byDmPtFrOZ1AXQCNT/+KhnC71le2rr45T0mjKB9mIQiWkE NwK/UX9jDAQkgqKYZ/BfXiMe5iBkcXM68gRRpQMVcHuFtHSqIl6/kesFYpxOcMoR zxk6KS8TNSfYzEK0QIC9Y+VlIw0cH9qZlQEAR0qvidmZ4lbX88xdFW28pNmNyqzG ypbC2e1pnzSDA7733doGe4eUWnTC9HhsANuK+LobUTcjNW6hMO2Fq2K/31xP0f8= =0P/T -----END PGP SIGNATURE----- --DGGME645iiF1d6Cd1q5UJpQwGWdPioMQp--