From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,PDS_BAD_THREAD_QP_64,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF56FC43462 for ; Thu, 15 Apr 2021 10:52:45 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8B96361222 for ; Thu, 15 Apr 2021 10:52:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8B96361222 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:41266 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lWzc4-0002TD-Mu for qemu-devel@archiver.kernel.org; Thu, 15 Apr 2021 06:52:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50674) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lWzam-0001UR-66 for qemu-devel@nongnu.org; Thu, 15 Apr 2021 06:51:24 -0400 Received: from mga18.intel.com ([134.134.136.126]:57963) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lWzah-0007UY-UL for qemu-devel@nongnu.org; Thu, 15 Apr 2021 06:51:23 -0400 IronPort-SDR: IB/R33rqc/SCjWx+nE7pX6lu3PJaMrIvGJ5SCTaNvoifPimLPtetKYmtP0xngoFrIy7zrV6eAy yMYp2PcdSE8Q== X-IronPort-AV: E=McAfee;i="6200,9189,9954"; a="182329370" X-IronPort-AV: E=Sophos;i="5.82,223,1613462400"; d="scan'208";a="182329370" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Apr 2021 03:51:16 -0700 IronPort-SDR: b2bT7zlls2Jp7jsyFYCRoxG9tNFnF17ErriA9FhRGmZIyggu7bkqoxZCp6Ur/+6/vWoYqoKCht hWtRUM231PVA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,223,1613462400"; d="scan'208";a="533095721" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by orsmga004.jf.intel.com with ESMTP; 15 Apr 2021 03:51:16 -0700 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Thu, 15 Apr 2021 03:51:15 -0700 Received: from shsmsx602.ccr.corp.intel.com (10.109.6.142) by SHSMSX601.ccr.corp.intel.com (10.109.6.141) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Thu, 15 Apr 2021 18:51:13 +0800 Received: from shsmsx602.ccr.corp.intel.com ([10.109.6.142]) by SHSMSX602.ccr.corp.intel.com ([10.109.6.142]) with mapi id 15.01.2106.013; Thu, 15 Apr 2021 18:51:13 +0800 From: "Zhang, Chen" To: "Dr. David Alan Gilbert" Subject: RE: [PATCH V4 1/7] qapi/net.json: Add IP_PROTOCOL definition Thread-Topic: [PATCH V4 1/7] qapi/net.json: Add IP_PROTOCOL definition Thread-Index: AQHXHHRwhE0xw39XiECnAJAI55tWJqqRf5aAgCDVHfA= Date: Thu, 15 Apr 2021 10:51:13 +0000 Message-ID: <5a9d9778f4784b4b96fa9e0831635c8d@intel.com> References: <20210319035508.113741-1-chen.zhang@intel.com> <20210319035508.113741-2-chen.zhang@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.5.1.3 dlp-reaction: no-action x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Received-SPF: pass client-ip=134.134.136.126; envelope-from=chen.zhang@intel.com; helo=mga18.intel.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lukas Straub , Li Zhijian , Jason Wang , qemu-dev , Markus Armbruster , Zhang Chen Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" > -----Original Message----- > From: Qemu-devel bounces+chen.zhang=3Dintel.com@nongnu.org> On Behalf Of Dr. David Alan > Gilbert > Sent: Wednesday, March 24, 2021 4:01 AM > To: Zhang, Chen > Cc: Lukas Straub ; Li Zhijian > ; Jason Wang ; qemu- > dev ; Markus Armbruster > ; Zhang Chen > Subject: Re: [PATCH V4 1/7] qapi/net.json: Add IP_PROTOCOL definition >=20 > * Zhang Chen (chen.zhang@intel.com) wrote: > > Add IP_PROTOCOL as enum include TCP,UDP, ICMP... for other QMP > commands. > > > > Signed-off-by: Zhang Chen > > --- > > qapi/net.json | 31 +++++++++++++++++++++++++++++++ > > 1 file changed, 31 insertions(+) > > > > diff --git a/qapi/net.json b/qapi/net.json index > > 87361ebd9a..498ea7aa72 100644 > > --- a/qapi/net.json > > +++ b/qapi/net.json > > @@ -794,3 +794,34 @@ > > # > > ## > > { 'command': 'query-netdev', 'returns': ['NetdevInfo'] } > > + > > +## > > +# @IP_PROTOCOL: > > +# > > +# Transport layer protocol. > > +# > > +# Just for IPv4. > > +# > > +# @tcp: Transmission Control Protocol. > > +# > > +# @udp: User Datagram Protocol. > > +# > > +# @dccp: Datagram Congestion Control Protocol. > > +# > > +# @sctp: Stream Control Transmission Protocol. > > +# > > +# @udplite: Lightweight User Datagram Protocol. > > +# > > +# @icmp: Internet Control Message Protocol. > > +# > > +# @igmp: Internet Group Management Protocol. > > +# > > +# @ipv6: IPv6 Encapsulation. > > +# > > +# TODO: Need to add more transport layer protocol. > > +# > > +# Since: 6.1 > > +## > > +{ 'enum': 'IP_PROTOCOL', 'data': [ 'tcp', 'udp', 'dccp', 'sctp', 'udpl= ite', > > + 'icmp', 'igmp', 'ipv6' ] } >=20 > Isn't the right thing to do here to use a string for protocol and then pa= ss it to > getprotobyname; that way your list is never out of date, and you never h= ave > to translate between the order of this enum and the integer assignment se= t > in stone. >=20 Hi Dave, Considering that most of the scenes in Qemu don't call the getprotobyname, = looks keep the string are more readable. Please review the V5 patches, Thanks. Thanks Chen > Dave >=20 > > + > > -- > > 2.25.1 > > > -- > Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK >=20