From: Dmitry Fomichev <Dmitry.Fomichev@wdc.com>
To: "stefanha@gmail.com" <stefanha@gmail.com>
Cc: "kwolf@redhat.com" <kwolf@redhat.com>,
"qemu-block@nongnu.org" <qemu-block@nongnu.org>,
"mst@redhat.com" <mst@redhat.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"mreitz@redhat.com" <mreitz@redhat.com>,
Alistair Francis <Alistair.Francis@wdc.com>,
"stefanha@redhat.com" <stefanha@redhat.com>,
"pbonzini@redhat.com" <pbonzini@redhat.com>,
"jsnow@redhat.com" <jsnow@redhat.com>
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH v5 0/4] virtio/block: handle zoned backing devices
Date: Wed, 4 Sep 2019 21:11:45 +0000 [thread overview]
Message-ID: <5f53bb6ca5f6281cf92f446a97b8823bdcded8da.camel@wdc.com> (raw)
In-Reply-To: <20190828094133.GG5573@stefanha-x1.localdomain>
On Wed, 2019-08-28 at 10:41 +0100, Stefan Hajnoczi wrote:
> On Fri, Aug 23, 2019 at 03:49:23PM -0400, Dmitry Fomichev wrote:
> > Dmitry Fomichev (4):
> > block: Add zoned device model property
> > raw: Recognize zoned backing devices
> > block/ide/scsi: Set BLK_PERM_SUPPORT_ZONED
> > raw: Don't open ZBDs if backend can't handle them
>
> The overall approach looks good.
>
> I wonder if bdrv_get_zoned_info() is really needed since zone_model is
> part of BlockLimits and is already fetched via bdrv_refresh_limits().
> Was it introduced because the block limits haven't been or cannot be
> fetched when zone_model is queried the first time? It would be nice to
> get rid of bdrv_get_zoned_info() if possible.
Stefan,
Thank you for your review. I've just sent out the new version of the
patchset, v6, that addresses you comments. I was able to get rid of
bdrv_get_zoned_info() template function as a part of the latest changes.
Best regards,
Dmitry
prev parent reply other threads:[~2019-09-04 22:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-23 19:49 [Qemu-devel] [PATCH v5 0/4] virtio/block: handle zoned backing devices Dmitry Fomichev
2019-08-23 19:49 ` [Qemu-devel] [PATCH v5 1/4] block: Add zoned device model property Dmitry Fomichev
2019-08-28 9:21 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2019-08-23 19:49 ` [Qemu-devel] [PATCH v5 2/4] raw: Recognize zoned backing devices Dmitry Fomichev
2019-08-28 9:32 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2019-08-23 19:49 ` [Qemu-devel] [PATCH v5 3/4] block/ide/scsi: Set BLK_PERM_SUPPORT_ZONED Dmitry Fomichev
2019-08-28 9:34 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2019-08-23 19:49 ` [Qemu-devel] [PATCH v5 4/4] raw: Don't open ZBDs if backend can't handle them Dmitry Fomichev
2019-08-28 9:38 ` Stefan Hajnoczi
2019-08-23 20:08 ` [Qemu-devel] [PATCH v5 0/4] virtio/block: handle zoned backing devices no-reply
2019-08-28 9:41 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2019-09-04 21:11 ` Dmitry Fomichev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5f53bb6ca5f6281cf92f446a97b8823bdcded8da.camel@wdc.com \
--to=dmitry.fomichev@wdc.com \
--cc=Alistair.Francis@wdc.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).