From: Richard Henderson <richard.henderson@linaro.org>
To: Andreas Krebbel <krebbel@linux.ibm.com>, qemu-devel@nongnu.org
Cc: qemu-s390x@nongnu.org, laurent@vivier.eu
Subject: Re: [PATCH v3] linux-user/s390x: Use the guest pointer for the sigreturn stub
Date: Thu, 25 Mar 2021 06:46:03 -0600 [thread overview]
Message-ID: <62161be8-2c92-8b51-284b-3e39af255b0f@linaro.org> (raw)
In-Reply-To: <20210324185128.63971-1-krebbel@linux.ibm.com>
On 3/24/21 12:51 PM, Andreas Krebbel wrote:
> When setting up the pointer for the sigreturn stub in the return
> address register (r14) we currently use the host frame address instead
> of the guest frame address.
>
> Note: This only caused problems if Qemu has been built with
> --disable-pie (as it is in distros nowadays). Otherwise guest_base
> defaults to 0 hiding the actual problem.
>
> Signed-off-by: Andreas Krebbel<krebbel@linux.ibm.com>
> ---
> linux-user/s390x/signal.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2021-03-25 12:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-24 18:51 [PATCH v3] linux-user/s390x: Use the guest pointer for the sigreturn stub Andreas Krebbel
2021-03-25 10:42 ` Laurent Vivier
2021-03-25 12:46 ` Richard Henderson [this message]
2021-03-25 19:55 ` Laurent Vivier
2021-03-26 6:51 ` Andreas Krebbel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62161be8-2c92-8b51-284b-3e39af255b0f@linaro.org \
--to=richard.henderson@linaro.org \
--cc=krebbel@linux.ibm.com \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).