From: Jason Wang <jasowang@redhat.com>
To: "Oleinik, Alexander" <alxndr@bu.edu>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [PATCH v4 19/20] fuzz: add virtio-net fuzz target
Date: Thu, 7 Nov 2019 21:42:33 +0800 [thread overview]
Message-ID: <66465e73-d009-ec62-58dd-279bfac6894c@redhat.com> (raw)
In-Reply-To: <20191030144926.11873-20-alxndr@bu.edu>
On 2019/10/30 下午10:50, Oleinik, Alexander wrote:
> From: Alexander Oleinik <alxndr@bu.edu>
>
> The virtio-net fuzz target feeds inputs to all three virtio-net
> virtqueues, and uses forking to avoid leaking state between fuzz runs.
>
> Signed-off-by: Alexander Oleinik <alxndr@bu.edu>
Can this fuzz vhost-net or vhost-user (I only see socket backend)? If
it's not too hard, it would be even more interesting.
Thanks
> ---
> tests/fuzz/Makefile.include | 1 +
> tests/fuzz/virtio_net_fuzz.c | 123 +++++++++++++++++++++++++++++++++++
> 2 files changed, 124 insertions(+)
> create mode 100644 tests/fuzz/virtio_net_fuzz.c
>
> diff --git a/tests/fuzz/Makefile.include b/tests/fuzz/Makefile.include
> index 37d6821bee..f1d9b46b1c 100644
> --- a/tests/fuzz/Makefile.include
> +++ b/tests/fuzz/Makefile.include
> @@ -6,5 +6,6 @@ fuzz-obj-y += tests/fuzz/fork_fuzz.o
> fuzz-obj-y += tests/fuzz/qos_fuzz.o
>
> fuzz-obj-y += tests/fuzz/i440fx_fuzz.o
> +fuzz-obj-y += tests/fuzz/virtio_net_fuzz.o
>
> FUZZ_LDFLAGS += -Xlinker -T$(SRC_PATH)/tests/fuzz/fork_fuzz.ld
> diff --git a/tests/fuzz/virtio_net_fuzz.c b/tests/fuzz/virtio_net_fuzz.c
> new file mode 100644
> index 0000000000..0543cfd32a
> --- /dev/null
> +++ b/tests/fuzz/virtio_net_fuzz.c
> @@ -0,0 +1,123 @@
> +/*
> + * virtio-net Fuzzing Target
> + *
> + * Copyright Red Hat Inc., 2019
> + *
> + * Authors:
> + * Alexander Bulekov <alxndr@bu.edu>
> + *
> + * This work is licensed under the terms of the GNU GPL, version 2 or later.
> + * See the COPYING file in the top-level directory.
> + */
> +
> +#include "qemu/osdep.h"
> +
> +#include "fuzz.h"
> +#include "fork_fuzz.h"
> +#include "qos_fuzz.h"
> +#include "tests/libqtest.h"
> +#include "tests/libqos/virtio-net.h"
> +
> +
> +static void virtio_net_fuzz_multi(QTestState *s,
> + const unsigned char *Data, size_t Size)
> +{
> + typedef struct vq_action {
> + uint8_t queue;
> + uint8_t length;
> + uint8_t write;
> + uint8_t next;
> + bool kick;
> + } vq_action;
> +
> + uint64_t req_addr[10];
> + int reqi = 0;
> + uint32_t free_head = 0;
> +
> + QGuestAllocator *t_alloc = fuzz_qos_alloc;
> +
> + QVirtioNet *net_if = fuzz_qos_obj;
> + QVirtioDevice *dev = net_if->vdev;
> + QVirtQueue *q;
> + vq_action vqa;
> + int iters = 0;
> + while (true) {
> + if (Size < sizeof(vqa)) {
> + break;
> + }
> + memcpy(&vqa, Data, sizeof(vqa));
> + vqa = *((vq_action *)Data);
> + Data += sizeof(vqa);
> + Size -= sizeof(vqa);
> +
> + q = net_if->queues[vqa.queue % 3];
> +
> + vqa.length = vqa.length >= Size ? Size : vqa.length;
> +
> + req_addr[reqi] = guest_alloc(t_alloc, vqa.length);
> + qtest_memwrite(s, req_addr[reqi], Data, vqa.length);
> + if (iters == 0) {
> + free_head = qvirtqueue_add(s, q, req_addr[reqi], vqa.length,
> + vqa.write, vqa.next);
> + } else {
> + qvirtqueue_add(s, q,
> + req_addr[reqi], vqa.length, vqa.write , vqa.next);
> + }
> + iters++;
> + reqi++;
> + if (iters == 10) {
> + break;
> + }
> + Data += vqa.length;
> + Size -= vqa.length;
> + }
> + if (iters) {
> + qvirtqueue_kick(s, dev, q, free_head);
> + qtest_clock_step_next(s);
> + for (int i = 0; i < reqi; i++) {
> + guest_free(t_alloc, req_addr[i]);
> + }
> + }
> +}
> +
> +static int *sv;
> +
> +static void *virtio_net_test_setup_socket(GString *cmd_line, void *arg)
> +{
> + if (!sv) {
> + sv = g_new(int, 2);
> + int ret = socketpair(PF_UNIX, SOCK_STREAM, 0, sv);
> + fcntl(sv[0], F_SETFL, O_NONBLOCK);
> + g_assert_cmpint(ret, !=, -1);
> + }
> + g_string_append_printf(cmd_line, " -netdev socket,fd=%d,id=hs0 ", sv[1]);
> + return arg;
> +}
> +
> +static void virtio_net_fork_fuzz(QTestState *s,
> + const unsigned char *Data, size_t Size)
> +{
> + if (fork() == 0) {
> + virtio_net_fuzz_multi(s, Data, Size);
> + flush_events(s);
> + _Exit(0);
> + } else {
> + wait(NULL);
> + }
> +}
> +
> +static void register_virtio_net_fuzz_targets(void)
> +{
> + fuzz_add_qos_target(&(FuzzTarget){
> + .name = "virtio-net-fork-fuzz",
> + .description = "Fuzz the virtio-net virtual queues, forking"
> + "for each fuzz run",
> + .pre_vm_init = &counter_shm_init,
> + .pre_fuzz = &qos_init_path,
> + .fuzz = virtio_net_fork_fuzz,},
> + "virtio-net",
> + &(QOSGraphTestOptions){.before = virtio_net_test_setup_socket}
> + );
> +}
> +
> +fuzz_target_init(register_virtio_net_fuzz_targets);
next prev parent reply other threads:[~2019-11-07 13:44 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-30 14:49 [PATCH v4 00/20] Add virtual device fuzzing support Oleinik, Alexander
2019-10-30 14:49 ` [PATCH v4 01/20] softmmu: split off vl.c:main() into main.c Oleinik, Alexander
2019-11-05 16:41 ` Darren Kenny
2019-11-12 16:46 ` Alexander Bulekov
2019-11-06 15:01 ` Stefan Hajnoczi
2019-10-30 14:49 ` [PATCH v4 02/20] libqos: Rename i2c_send and i2c_recv Oleinik, Alexander
2019-11-06 15:17 ` Stefan Hajnoczi
2019-10-30 14:49 ` [PATCH v4 03/20] fuzz: Add FUZZ_TARGET module type Oleinik, Alexander
2019-11-06 13:17 ` Darren Kenny
2019-11-06 15:18 ` Stefan Hajnoczi
2019-10-30 14:49 ` [PATCH v4 04/20] qtest: add qtest_server_send abstraction Oleinik, Alexander
2019-11-06 13:29 ` Darren Kenny
2019-11-06 15:19 ` Stefan Hajnoczi
2019-10-30 14:49 ` [PATCH v4 06/20] module: check module wasn't already initialized Oleinik, Alexander
2019-11-06 15:26 ` Stefan Hajnoczi
2019-11-06 17:40 ` Darren Kenny
2019-10-30 14:49 ` [PATCH v4 05/20] libqtest: Add a layer of abstraciton to send/recv Oleinik, Alexander
2019-11-06 16:22 ` Stefan Hajnoczi
2019-10-30 14:49 ` [PATCH v4 07/20] qtest: add in-process incoming command handler Oleinik, Alexander
2019-11-06 16:33 ` Stefan Hajnoczi
2019-10-30 14:49 ` [PATCH v4 08/20] tests: provide test variables to other targets Oleinik, Alexander
2019-11-07 14:32 ` Darren Kenny
2019-10-30 14:49 ` [PATCH v4 09/20] libqos: split qos-test and libqos makefile vars Oleinik, Alexander
2019-11-07 14:03 ` Darren Kenny
2019-10-30 14:49 ` [PATCH v4 10/20] libqos: move useful qos-test funcs to qos_external Oleinik, Alexander
2019-11-06 16:41 ` Stefan Hajnoczi
2019-10-30 14:49 ` [PATCH v4 11/20] libqtest: make qtest_bufwrite send "atomic" Oleinik, Alexander
2019-11-06 16:44 ` Stefan Hajnoczi
2019-10-30 14:49 ` [PATCH v4 12/20] libqtest: add in-process qtest.c tx/rx handlers Oleinik, Alexander
2019-11-06 16:56 ` Stefan Hajnoczi
2019-11-12 17:38 ` Alexander Bulekov
2019-10-30 14:49 ` [PATCH v4 13/20] fuzz: add configure flag --enable-fuzzing Oleinik, Alexander
2019-11-06 16:57 ` Stefan Hajnoczi
2019-10-30 14:50 ` [PATCH v4 15/20] fuzz: add fuzzer skeleton Oleinik, Alexander
2019-11-07 12:55 ` Stefan Hajnoczi
2019-11-12 19:04 ` Alexander Bulekov
2019-10-30 14:50 ` [PATCH v4 14/20] fuzz: Add target/fuzz makefile rules Oleinik, Alexander
2019-11-07 14:31 ` Darren Kenny
2019-10-30 14:50 ` [PATCH v4 16/20] fuzz: add support for fork-based fuzzing Oleinik, Alexander
2019-11-07 13:17 ` Stefan Hajnoczi
2019-10-30 14:50 ` [PATCH v4 17/20] fuzz: add support for qos-assisted fuzz targets Oleinik, Alexander
2019-11-07 13:22 ` Stefan Hajnoczi
2019-10-30 14:50 ` [PATCH v4 18/20] fuzz: add i440fx " Oleinik, Alexander
2019-11-07 13:26 ` Stefan Hajnoczi
2019-10-30 14:50 ` [PATCH v4 19/20] fuzz: add virtio-net fuzz target Oleinik, Alexander
2019-11-07 13:36 ` Stefan Hajnoczi
2019-11-07 13:42 ` Jason Wang [this message]
2019-11-07 15:41 ` Stefan Hajnoczi
2019-10-30 14:50 ` [PATCH v4 20/20] fuzz: add documentation to docs/devel/ Oleinik, Alexander
2019-11-07 13:40 ` Stefan Hajnoczi
2019-11-07 15:02 ` Alexander Oleinik
2019-10-30 15:23 ` [PATCH v4 00/20] Add virtual device fuzzing support no-reply
2019-11-06 15:27 ` Stefan Hajnoczi
2019-11-05 13:57 ` Darren Kenny
2019-11-05 16:28 ` Alexander Oleinik
2019-11-05 16:47 ` Darren Kenny
2019-11-07 13:41 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66465e73-d009-ec62-58dd-279bfac6894c@redhat.com \
--to=jasowang@redhat.com \
--cc=alxndr@bu.edu \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).