From: Eric Blake <eblake@redhat.com>
To: "Hu, Robert" <robert.hu@intel.com>,
Robert Hoo <robert.hu@linux.intel.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"pbonzini@redhat.com" <pbonzini@redhat.com>,
"richard.henderson@linaro.org" <richard.henderson@linaro.org>
Subject: Re: [PATCH 2/2] util/bufferiszero: improve avx2 accelerator
Date: Thu, 26 Mar 2020 08:26:03 -0500 [thread overview]
Message-ID: <6c9cee4c-8d3b-ed9d-7345-fbaea33477ca@redhat.com> (raw)
In-Reply-To: <9E79D1C9A97CFD4097BCE431828FDD31178F147A@SHSMSX104.ccr.corp.intel.com>
On 3/25/20 9:09 PM, Hu, Robert wrote:
> (Don't know why my Linux-Evolution missed this mail.)
>> -----Original Message-----
>> Long line; it's nice to wrap commit messages around column 70 or so (because
>> reading 'git log' in an 80-column window adds indentation).
>>
> [Hu, Robert]
> I think I set my vim on wrap. This probably escaped by paste.
> I ran checkpatch.pl on the patches before sending. It escaped check but didn't
> escaped your eagle eye😊 Thank you.
checkpatch doesn't flag commit message long lines. Maybe it could be
patched to do so, but it's not at the top of my list to write that patch.
>
>>> I just fix a boudary case on his original patch.
>>
>> boundary
> [Hu, Robert]
> Emm... again spell error. Usually I would paste descriptions into some editors
> with spell check, but forgot this time.
> Vim doesn't have spell check I think. What editor would you suggest me to
> integrate with git editing?
I'm an emacs user, so I have no suggestions for vim, but I'd be very
surprised if there were not some vim expert online that could figure out
how to wire in a spell-checker to vim. Google quickly finds:
https://www.ostechnix.com/use-spell-check-feature-vim-text-editor/
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2020-03-26 13:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-25 6:50 [PATCH 1/2] util/bufferiszero: assign length_to_accel value for each accelerator case Robert Hoo
2020-03-25 6:50 ` [PATCH 2/2] util/bufferiszero: improve avx2 accelerator Robert Hoo
2020-03-25 12:54 ` Eric Blake
2020-03-26 2:09 ` Hu, Robert
2020-03-26 9:43 ` Paolo Bonzini
2020-03-26 13:26 ` Eric Blake [this message]
2020-03-26 13:51 ` Robert Hoo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c9cee4c-8d3b-ed9d-7345-fbaea33477ca@redhat.com \
--to=eblake@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=robert.hu@intel.com \
--cc=robert.hu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).