From: Paolo Bonzini <pbonzini@redhat.com>
To: "Thomas Huth" <thuth@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
qemu-devel@nongnu.org,
"David Gibson" <david@gibson.dropbear.id.au>,
"Hervé Poussineau" <hpoussin@reactos.org>
Cc: Laurent Vivier <lvivier@redhat.com>
Subject: Re: [PATCH] hw/ppc/prep: Remove the deprecated "prep" machine and the OpenHackware BIOS
Date: Tue, 3 Dec 2019 14:04:07 +0100 [thread overview]
Message-ID: <7528162c-ce2f-985e-7f58-9267389edd33@redhat.com> (raw)
In-Reply-To: <f9c24324-b04a-f88c-3da7-3dfd2041b048@redhat.com>
On 03/12/19 10:15, Thomas Huth wrote:
>>>> Maybe we can rename this as read_boot_order_mm, and the previous
>>>> read_boot_order_pc as read_boot_order_io.
>>>
>>> I don't think it makes much sense. This was completely specific to the
>>> "prep" machine, even the "40p" machine seems to prefer fw_cfg nowadays.
>>> So let's simply remove this old stuff.
>>>
>>>> diff --git a/tests/endianness-test.c b/tests/endianness-test.c
>>>> index 58527952a5..2798802c63 100644
>>>> --- a/tests/endianness-test.c
>>>> +++ b/tests/endianness-test.c
>>>> @@ -35,7 +35,7 @@ static const TestCase test_cases[] = {
>>>> { "mips64", "malta", 0x10000000, .bswap = true },
>>>> { "mips64el", "fulong2e", 0x1fd00000 },
>>>> { "ppc", "g3beige", 0xfe000000, .bswap = true, .superio =
>>>> "i82378" },
>>>> - { "ppc", "prep", 0x80000000, .bswap = true },
>>>> + { "ppc", "40p", 0x80000000, .bswap = true },
>>
>> ... here you access the Super I/O behind the PCI bridge via MMIO?
>
> The difference is that this is an *arbitrary* address in I/O space
> there.
No, it's the base address of the ISA space, to which the tests add the
address of the pc-testdev device. It's not any different from the
0x80000000 in boot-order-test.
That said, I think it's a sensible objection that boot order doesn't
come from m48t59 on 40p (does it not?). The m48t59-test could also be
adjusted to test the 40p... the right way to do it would be to have an
ISA bridge driver in qgraph, but that's a topic for a separate series.
Thanks,
Paolo
> It's not an address of a certain PCI device like the m48t59
> behind a PCI-bridge. As long as it's possible to write and read from
> this address, the test is working. Both, the "prep" and the "40p"
> machine have the "raven-pcihost" device at this address, so in this case
> the switch from "40p" to "prep" was easily possible.
>
> Thomas
>
>
next prev parent reply other threads:[~2019-12-03 13:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-03 7:29 [PATCH] hw/ppc/prep: Remove the deprecated "prep" machine and the OpenHackware BIOS Thomas Huth
2019-12-03 7:45 ` Philippe Mathieu-Daudé
2019-12-03 8:25 ` Thomas Huth
2019-12-03 8:51 ` Philippe Mathieu-Daudé
2019-12-03 9:15 ` Thomas Huth
2019-12-03 9:21 ` Philippe Mathieu-Daudé
2019-12-03 13:04 ` Paolo Bonzini [this message]
2019-12-03 13:16 ` Thomas Huth
2019-12-03 13:39 ` Paolo Bonzini
2019-12-03 22:36 ` Mark Cave-Ayland
2020-01-07 9:22 ` Thomas Huth
2020-01-07 21:21 ` Hervé Poussineau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7528162c-ce2f-985e-7f58-9267389edd33@redhat.com \
--to=pbonzini@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=hpoussin@reactos.org \
--cc=lvivier@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).