From: Maxim Levitsky <mlevitsk@redhat.com>
To: Max Reitz <mreitz@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v5] LUKS: support preallocation
Date: Sun, 21 Jul 2019 11:36:21 +0300 [thread overview]
Message-ID: <7a1f4f24223a0d095f281b0f11f599e6682264d1.camel@redhat.com> (raw)
In-Reply-To: <cbff0508-834b-3c52-bbe7-35046485c1e9@redhat.com>
On Fri, 2019-07-19 at 12:28 +0200, Max Reitz wrote:
> On 16.07.19 18:19, Maxim Levitsky wrote:
> > preallocation=off and preallocation=metadata
> > both allocate luks header only, and preallocation=falloc/full
> > is passed to underlying file.
> >
> > Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1534951
> >
> > Signed-off-by: Maxim Levitsky <mlevitsk@redhat.com>
> > ---
> >
> > This is hopefully a revision without coding style violations.
> >
> > Note that I still haven't tested the blockdev-create code, other that
> > compile testing it.
> >
> > Best regards,
> > Maxim Levitsky
> >
> >
> > block/crypto.c | 30 +++++++++++++++++++++++++++---
> > qapi/block-core.json | 6 +++++-
> > 2 files changed, 32 insertions(+), 4 deletions(-)
>
> Thanks, applied to my block-next branch for 4.2:
>
> https://git.xanclic.moe/XanClic/qemu/commits/branch/block-next
>
> Max
>
> (The Patchew warning doesn’t look like it’s caused by this patch.)
>
Thank you!!
Best regards,
Maxim Levitsky
prev parent reply other threads:[~2019-07-21 8:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-16 16:19 [Qemu-devel] [PATCH v5] LUKS: support preallocation Maxim Levitsky
2019-07-17 16:56 ` no-reply
2019-07-19 10:28 ` Max Reitz
2019-07-21 8:36 ` Maxim Levitsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7a1f4f24223a0d095f281b0f11f599e6682264d1.camel@redhat.com \
--to=mlevitsk@redhat.com \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).