From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F0BBC433DB for ; Fri, 12 Feb 2021 19:19:03 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3C0D764DD5 for ; Fri, 12 Feb 2021 19:19:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3C0D764DD5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:43260 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lAdy2-0002Nm-Ch for qemu-devel@archiver.kernel.org; Fri, 12 Feb 2021 14:19:02 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:42342) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lAdhx-0004mj-2C for qemu-devel@nongnu.org; Fri, 12 Feb 2021 14:02:26 -0500 Received: from mail-pl1-x636.google.com ([2607:f8b0:4864:20::636]:33693) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lAdhs-0004jg-Dt for qemu-devel@nongnu.org; Fri, 12 Feb 2021 14:02:23 -0500 Received: by mail-pl1-x636.google.com with SMTP id d13so355665plg.0 for ; Fri, 12 Feb 2021 11:02:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=c0jW8f+uLR0EOQqwEQzfLGv/rCn+PF5svD+SH9wzQmc=; b=HKW5tAyHTnVkHKeWNL9whaHy1QwphsKUCzaMFy+OofIQ32wyVusldAJjYxCKj5kC67 YOwC4GM2vlYOL5HIwwfPMlKebi5gDlyi/IDzJGEEIZUhrNzgZ4J1g/W2fIz+v49k5xk4 w5UUIf+O+EzJJhUJhfedMiywPDkT9OPGsmPsn0XDcqGeFIRbjOPjTh9OpYE8/8BsOOXz sNq9lWH5a3De5CxrMOVCSvS0KF2AApvaBw5aHWTNWIH2fGkrdmSEas3fwh6Tpifmw/cU nyhdIStycPD6JSfTxe4Y7Oj3AwDF38AI5zMs5BB0HfKGwebxWerGDBhsx9YreaIzx10p 3Uig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=c0jW8f+uLR0EOQqwEQzfLGv/rCn+PF5svD+SH9wzQmc=; b=juhlxZZOpfS0Qtl+jX13aamM6zinNWQbmaGDmE35ok7zdj4hbkz2r/DRpouMfuKUww IPQgyHqcHubCHP7TkTda3BOOf4bESyrzjPMx79D5T8ZVxJ8XHDYIWmDScAyX9cYBMjCd PXh9KcMX0V803BKe0f/L1zcrB8nJ7SmWazQ/2/B7n1U+aMP7ZrZCOm2tujCZQ6pW57mn ItB3MZ1UdsWfVqAMw3Z02QvUgDEE9R4yIo3Xea43EFVRZnbq6JBrOsMbtURz8laLHqI6 gXlLqYiMcN15cnCilyInluLQKb0eMD/dEXFfEmC+PcYQS8uyzgURBrsBNy2TavV1qjIz Q8/w== X-Gm-Message-State: AOAM530lTMFDlJTe4hmtI91Y9/CIJKEviaiE+E+j1xadTcQ+hvBb0w5f hQV+irtb/w86iZsrap1a1x3VWw== X-Google-Smtp-Source: ABdhPJzItrb7ZS5U1oz/h8OGIL5Q+rt0Z0cNuox7f49NezNBajLCSIr7D0Begkgxrjp3DYtyEJHcPg== X-Received: by 2002:a17:902:e84e:b029:e2:dbb6:73f8 with SMTP id t14-20020a170902e84eb02900e2dbb673f8mr3912871plg.52.1613156538888; Fri, 12 Feb 2021 11:02:18 -0800 (PST) Received: from [192.168.1.11] (174-21-150-71.tukw.qwest.net. [174.21.150.71]) by smtp.gmail.com with ESMTPSA id w3sm8831321pjb.2.2021.02.12.11.02.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 12 Feb 2021 11:02:18 -0800 (PST) Subject: Re: [PATCH 04/38] target/riscv: 16-bit Addition & Subtraction Instructions To: LIU Zhiwei , qemu-devel@nongnu.org References: <20210212150256.885-1-zhiwei_liu@c-sky.com> <20210212150256.885-5-zhiwei_liu@c-sky.com> From: Richard Henderson Message-ID: <7e459e06-7405-e01c-02c7-79dabf4ceb70@linaro.org> Date: Fri, 12 Feb 2021 11:02:16 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210212150256.885-5-zhiwei_liu@c-sky.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::636; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x636.google.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.119, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alistair23@gmail.com, qemu-riscv@nongnu.org, palmer@dabbelt.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 2/12/21 7:02 AM, LIU Zhiwei wrote: > +static void tcg_gen_simd_add16(TCGv d, TCGv a, TCGv b) > +{ > + TCGv t1 = tcg_temp_new(); > + TCGv t2 = tcg_temp_new(); > + > + tcg_gen_andi_tl(t1, a, ~0xffff); > + tcg_gen_add_tl(t2, a, b); > + tcg_gen_add_tl(t1, t1, b); > + tcg_gen_deposit_tl(d, t1, t2, 0, 16); > + > + tcg_temp_free(t1); > + tcg_temp_free(t2); > +} I will note that there are some helper functions, e.g. tcg_gen_vec_add16_i64 (see the end of include/tcg/tcg-op-gvec.h), but those are explicitly i64, and you'll still need these for rv32. r~