From: Markus Armbruster <armbru@redhat.com>
To: Li Zhang <zhlcindy@gmail.com>
Cc: marcandre.lureau@redhat.com, Li Zhang <li.zhang@cloud.ionos.com>,
qemu-devel@nongnu.org, Pankaj Gupta <pankaj.gupta@ionos.com>
Subject: Re: [PATCHv2 1/1] Support monitor chardev hotswap with QMP
Date: Sat, 17 Apr 2021 10:05:08 +0200 [thread overview]
Message-ID: <877dl12v63.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <CAD8of+ouCK6gd5ur6Eq23EJy_y3a_OV9wkBDBivp+tOkbzagTQ@mail.gmail.com> (Li Zhang's message of "Fri, 16 Apr 2021 17:20:44 +0200")
Li Zhang <zhlcindy@gmail.com> writes:
> On Fri, Apr 16, 2021 at 4:50 PM Markus Armbruster <armbru@redhat.com> wrote:
[...]
>> As I wrote in my review of v1, this function copies from
>> monitor_data_init(), monitor_init_qmp(), and monitor_flush_locked().
>> Feels like a refactoring would be in order. Doing it on top might be
>> easier.
>
> I may misunderstand what you mean. What's the meaning of "doing it on
> top" exactly?
As a separate patch on top of this one. Sorry for the jargon :)
[...]
prev parent reply other threads:[~2021-04-17 8:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-13 21:34 [PATCHv2 1/1] Support monitor chardev hotswap with QMP Li Zhang
2021-04-15 15:07 ` Li Zhang
2021-04-16 14:50 ` Markus Armbruster
2021-04-16 14:59 ` Marc-André Lureau
2021-04-16 15:28 ` Marc-André Lureau
2021-04-16 15:46 ` Li Zhang
2021-04-17 8:02 ` Markus Armbruster
2021-04-19 11:56 ` Li Zhang
2021-05-04 6:29 ` Pankaj Gupta
2021-05-04 8:38 ` Daniel P. Berrangé
2021-04-16 15:20 ` Li Zhang
2021-04-17 8:05 ` Markus Armbruster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877dl12v63.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=li.zhang@cloud.ionos.com \
--cc=marcandre.lureau@redhat.com \
--cc=pankaj.gupta@ionos.com \
--cc=qemu-devel@nongnu.org \
--cc=zhlcindy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).