From: Markus Armbruster <armbru@redhat.com>
To: Aleksandar Markovic <aleksandar.markovic@rt-rk.com>
Cc: aleksandar.rikalo@rt-rk.com, qemu-devel@nongnu.org
Subject: Re: [PATCH v3 1/6] target/mips: Clean up helper.c
Date: Mon, 14 Oct 2019 09:25:52 +0200 [thread overview]
Message-ID: <87eezf6b5r.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <1570901866-9548-2-git-send-email-aleksandar.markovic@rt-rk.com> (Aleksandar Markovic's message of "Sat, 12 Oct 2019 19:37:41 +0200")
Aleksandar Markovic <aleksandar.markovic@rt-rk.com> writes:
> From: Aleksandar Markovic <amarkovic@wavecomp.com>
>
> Mostly fix errors and warnings reported by 'checkpatch.pl -f'.
>
> Signed-off-by: Aleksandar Markovic <amarkovic@wavecomp.com>
> ---
> target/mips/helper.c | 128 +++++++++++++++++++++++++++++++--------------------
> 1 file changed, 78 insertions(+), 50 deletions(-)
>
> diff --git a/target/mips/helper.c b/target/mips/helper.c
> index a2b6459..2411a2c 100644
> --- a/target/mips/helper.c
> +++ b/target/mips/helper.c
[...]
> @@ -130,8 +133,11 @@ static int is_seg_am_mapped(unsigned int am, bool eu, int mmu_idx)
> int32_t adetlb_mask;
>
> switch (mmu_idx) {
> - case 3 /* ERL */:
> - /* If EU is set, always unmapped */
> + case 3:
> + /*
> + * ERL
> + * If EU is set, always unmapped
> + */
> if (eu) {
> return 0;
> }
Did you miss my review comment?
Message-ID: <874l0ydk00.fsf@dusky.pond.sub.org>
https://lists.nongnu.org/archive/html/qemu-devel/2019-09/msg06719.html
[...]
next prev parent reply other threads:[~2019-10-14 7:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-12 17:37 [PATCH v3 0/6] target/mips: Misc cleanups for September/October 2019 Aleksandar Markovic
2019-10-12 17:37 ` [PATCH v3 1/6] target/mips: Clean up helper.c Aleksandar Markovic
2019-10-14 7:25 ` Markus Armbruster [this message]
2019-10-14 8:22 ` Aleksandar Markovic
2019-10-12 17:37 ` [PATCH v3 2/6] target/mips: Clean up op_helper.c Aleksandar Markovic
2019-10-12 17:37 ` [PATCH v3 3/6] MAINTAINERS: Update mail address of Aleksandar Rikalo Aleksandar Markovic
2019-10-12 17:37 ` [PATCH v3 4/6] target/mips: msa: Split helpers for <MAX|MIN>_A.<B|H|W|D> Aleksandar Markovic
2019-10-12 17:37 ` [PATCH v3 5/6] target/mips: msa: Split helpers for <MAX|MIN>_<S|U>.<B|H|W|D> Aleksandar Markovic
2019-10-12 17:37 ` [PATCH v3 6/6] target/mips: msa: Split helpers for ILV<EV|OD|L|R>.<B|H|W|D> Aleksandar Markovic
2019-10-12 18:13 ` [PATCH v3 0/6] target/mips: Misc cleanups for September/October 2019 no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eezf6b5r.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=aleksandar.markovic@rt-rk.com \
--cc=aleksandar.rikalo@rt-rk.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).