From: "Alex Bennée" <alex.bennee@linaro.org>
To: "Lluís Vilanova" <vilanova@ac.upc.edu>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Eduardo Habkost <ehabkost@redhat.com>,
Richard Henderson <rth@twiddle.net>,
Stefan Hajnoczi <stefanha@gmail.com>,
Anthony Green <green@moxielogic.com>,
Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,
qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>,
Blue Swirl <blauwirbel@gmail.com>,
Max Filippov <jcmvbkbc@gmail.com>,
Michael Walle <michael@walle.cc>,
"open list:ARM" <qemu-arm@nongnu.org>,
"open list:PowerPC" <qemu-ppc@nongnu.org>,
Stefan Hajnoczi <stefanha@redhat.com>,
Bastian Koppelmann <kbastian@mail.uni-paderborn.de>,
Paolo Bonzini <pbonzini@redhat.com>,
Guan Xuetao <gxt@mprc.pku.edu.cn>,
Leon Alrae <leon.alrae@imgtec.com>,
Aurelien Jarno <aurelien@aurel32.net>, Jia Liu <proljc@gmail.com>
Subject: Re: [Qemu-devel] [Qemu-arm] [PATCH v5 1/2] trace: Add support for vCPU pointers in trace events
Date: Mon, 08 Feb 2016 19:46:49 +0000 [thread overview]
Message-ID: <87io1zvvbq.fsf@linaro.org> (raw)
In-Reply-To: <145408498416.24960.1155193592028104008.stgit@localhost>
Lluís Vilanova <vilanova@ac.upc.edu> writes:
> The tracing infrastructure later needs to differentiate between regular
> pointers and pointers to vCPUs.
>
> Also changes all targets to use the new 'TCGv_cpu' type instead of the
> generic 'TCGv_ptr'. As of now, the change is merely cosmetic ('TCGv_cpu'
> translates into 'TCGv_ptr'), but that could change in the future to
> enforce the difference.
>
> Signed-off-by: Lluís Vilanova <vilanova@ac.upc.edu>
> ---
> include/qemu/typedefs.h | 1 +
> scripts/tracetool/transform.py | 9 ++++++++-
> target-alpha/translate.c | 2 +-
> target-arm/translate.c | 2 +-
> target-arm/translate.h | 2 +-
> target-cris/translate.c | 2 +-
> target-i386/translate.c | 2 +-
> target-lm32/translate.c | 2 +-
> target-m68k/translate.c | 2 +-
> target-microblaze/translate.c | 2 +-
> target-mips/translate.c | 2 +-
> target-moxie/translate.c | 2 +-
> target-openrisc/translate.c | 2 +-
> target-ppc/translate.c | 2 +-
> target-s390x/translate.c | 2 +-
> target-sh4/translate.c | 2 +-
> target-sparc/translate.c | 5 +++--
> target-tilegx/translate.c | 2 +-
> target-tricore/translate.c | 2 +-
> target-unicore32/translate.c | 2 +-
> target-xtensa/translate.c | 2 +-
> tcg/tcg-op.h | 2 --
> tcg/tcg.h | 6 ++++++
> trace/control.h | 3 ++-
> 24 files changed, 38 insertions(+), 24 deletions(-)
>
> diff --git a/include/qemu/typedefs.h b/include/qemu/typedefs.h
> index 78fe6e8..efbc8a9 100644
> --- a/include/qemu/typedefs.h
> +++ b/include/qemu/typedefs.h
> @@ -18,6 +18,7 @@ typedef struct BusState BusState;
> typedef struct CharDriverState CharDriverState;
> typedef struct CompatProperty CompatProperty;
> typedef struct CPUAddressSpace CPUAddressSpace;
> +typedef struct CPUState CPUState;
> typedef struct DeviceListener DeviceListener;
> typedef struct DeviceState DeviceState;
> typedef struct DisplayChangeListener DisplayChangeListener;
> diff --git a/scripts/tracetool/transform.py b/scripts/tracetool/transform.py
> index fc5e679..8a43a4e 100644
> --- a/scripts/tracetool/transform.py
> +++ b/scripts/tracetool/transform.py
> @@ -6,7 +6,7 @@ Type-transformation rules.
> """
>
> __author__ = "Lluís Vilanova <vilanova@ac.upc.edu>"
> -__copyright__ = "Copyright 2012-2014, Lluís Vilanova <vilanova@ac.upc.edu>"
> +__copyright__ = "Copyright 2012-2016, Lluís Vilanova <vilanova@ac.upc.edu>"
> __license__ = "GPL version 2 or (at your option) any later version"
>
> __maintainer__ = "Stefan Hajnoczi"
> @@ -74,6 +74,7 @@ TCG_2_HOST = {
> "TCGv_i32": "uint32_t",
> "TCGv_i64": "uint64_t",
> "TCGv_ptr": "void *",
> + "TCGv_cpu": "CPUState *",
> None: _tcg_2_host,
> }
>
> @@ -98,6 +99,7 @@ HOST_2_TCG = {
> "uint32_t": "TCGv_i32",
> "uint64_t": "TCGv_i64",
> "void *" : "TCGv_ptr",
> + "CPUState *": "TCGv_cpu",
> None: _host_2_tcg,
> }
>
> @@ -115,6 +117,8 @@ TCG_2_TCG_HELPER_DEF = {
<snip>
> +typedef TCGv_ptr TCGv_cpu;
> +#if TARGET_LONG_BITS == 32
> +typedef TCGv_i32 TCGv;
> +#else /* TARGET_LONG_BITS == 64 */
> +typedef TCGv_i64 TCGv;
> +#endif
BTW something is amiss in the encoding for these patches as
checkpatch.pl barfed on:
+typedef TCGv_ptr TCGv_cpu;
+#if TARGET_LONG_BITS =3D=3D 32
+typedef TCGv_i32 TCGv;
+#else /* TARGET_LONG_BITS =3D=3D 64 */
+typedef TCGv_i64 TCGv;
+#endif
It might just be your outgoing email gateway being fancy:
X-MIME-Autoconverted: from 8bit to quoted-printable by roura.ac.upc.es
id
u0TGTjbf023394
--
Alex Bennée
next prev parent reply other threads:[~2016-02-08 19:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-29 16:29 [Qemu-devel] [PATCH v5 0/2] trace: Show vCPU info in guest code events Lluís Vilanova
2016-01-29 16:29 ` [Qemu-devel] [PATCH v5 1/2] trace: Add support for vCPU pointers in trace events Lluís Vilanova
2016-02-08 19:37 ` [Qemu-devel] [Qemu-arm] " Alex Bennée
2016-02-09 12:02 ` Lluís Vilanova
2016-02-09 21:06 ` Lluís Vilanova
2016-02-08 19:46 ` Alex Bennée [this message]
2016-02-09 12:05 ` Lluís Vilanova
2016-01-29 16:29 ` [Qemu-devel] [PATCH v5 2/2] trace: Add 'vcpu' event property to trace guest vCPU Lluís Vilanova
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87io1zvvbq.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=agraf@suse.de \
--cc=aurelien@aurel32.net \
--cc=blauwirbel@gmail.com \
--cc=ehabkost@redhat.com \
--cc=green@moxielogic.com \
--cc=gxt@mprc.pku.edu.cn \
--cc=jcmvbkbc@gmail.com \
--cc=kbastian@mail.uni-paderborn.de \
--cc=leon.alrae@imgtec.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=michael@walle.cc \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=proljc@gmail.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=rth@twiddle.net \
--cc=stefanha@gmail.com \
--cc=stefanha@redhat.com \
--cc=vilanova@ac.upc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).