Re: [PATCH v5 8/8] multifd: Add zstd compression multifd support

[Juan Quintela <quintela@redhat.com>]

"Dr. David Alan Gilbert" <dgilbert@redhat.com> wrote:
> * Juan Quintela (quintela@redhat.com) wrote:
>> Signed-off-by: Juan Quintela <quintela@redhat.com>
>> ---
>>  hw/core/qdev-properties.c    |   2 +-
>>  migration/Makefile.objs      |   1 +
>>  migration/migration.c        |   9 +
>>  migration/migration.h        |   1 +
>>  migration/multifd-zstd.c     | 337 +++++++++++++++++++++++++++++++++++
>>  migration/multifd.h          |   2 +-
>>  migration/ram.c              |   1 -
>>  qapi/migration.json          |   4 +-
>>  tests/qtest/migration-test.c |  10 ++
>>  9 files changed, 363 insertions(+), 4 deletions(-)
>>  create mode 100644 migration/multifd-zstd.c

>> +    res = ZSTD_initCStream(z->zcs, migrate_multifd_zstd_level());
>> +    if (ZSTD_isError(res)) {
>> +        ZSTD_freeCStream(z->zcs);
>> +        g_free(z);
>> +        error_setg(errp, "multifd %d: initCStream failed", p->id);
>
> It might be useful to print 'res' here - you seem to decode it on the
> receive side.

Fixed all callers.

>> @@ -163,6 +164,5 @@ typedef struct {
>>  } MultiFDMethods;
>>  
>>  void multifd_register_ops(int method, MultiFDMethods *ops);
>> -
>
> Oddment.

oops.  Removed the chunk.
>
>
> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>

Thanks.