qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Kevin Wolf <kwolf@redhat.com>, Fam Zheng <famz@redhat.com>,
	Stefan Weil <sw@weilnetz.de>,
	QEMU Developers <qemu-devel@nongnu.org>,
	Stefan Hajnoczi <stefanha@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>, John Snow <jsnow@redhat.com>,
	David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [Qemu-devel] [PATCH 06/12] docker: Add basic test
Date: Mon, 15 Feb 2016 14:52:23 +0000	[thread overview]
Message-ID: <87si0um3fc.fsf@linaro.org> (raw)
In-Reply-To: <CAFEAcA_xVFD+4=D8AkzeLBoT1_gYX8_6gZAu9iXa+-Febq3pqw@mail.gmail.com>


Peter Maydell <peter.maydell@linaro.org> writes:

> On 15 February 2016 at 14:34, Alex Bennée <alex.bennee@linaro.org> wrote:
>>
>> Fam Zheng <famz@redhat.com> writes:
>>> +cd $(mktemp -d)
>>> +mkdir build
>>> +mkdir install
>>> +cd build
>>> +build_qemu --target-list=x86_64-softmmu --prefix="${pwd}/install"
>
> Why restrict the target list ?
>
>>> +make check $MAKEFLAGS
>>> +make install
>>
>> From my excursions last week into the tests directory I discovered the
>> unit tests are built for a number of different qtest binaries. For
>> completeness we should probably include the whole list:
>>
>> #+name: qtest-targets
>> #+begin_src sh :dir ~/lsrc/qemu/qemu.git :results scalar
>> grep -E "check-qtest-[[:alnum:]]+-y " tests/Makefile | cut -d " " -f 1 | sort -u
>> #+end_src
>>
>> #+RESULTS: qtest-targets
>> #+begin_example
>> check-qtest-arm-y
>> check-qtest-generic-y
>> check-qtest-i386-y
>> check-qtest-ipack-y
>> check-qtest-microblazeel-y
>> check-qtest-mips64el-y
>> check-qtest-mips64-y
>> check-qtest-mips-y
>> check-qtest-pci-y
>> check-qtest-ppc64-y
>> check-qtest-ppc-y
>> check-qtest-sh4eb-y
>> check-qtest-sh4-y
>> #check-qtest-sparc64-y
>> check-qtest-sparc64-y
>> #check-qtest-sparc-y
>> check-qtest-virtioserial-y
>> check-qtest-virtio-y
>> check-qtest-x86_64-y
>> check-qtest-xtensaeb-y
>> check-qtest-y
>> #+end_example
>
> I'm having difficulty figuring out what you're proposing here,
> but it looks like you're suggesting listing all the check-qtest-*
> test names again here, which seems worth avoiding. We should
> just do a build and make check and let that take care of
> running all the tests.

Well there is a halfway house between building one target and building
all possible targets. Not all the softmmu targets include additional
tests. Having said that it is probably simpler as you say to just build
everything.

>
> thanks
> -- PMM


--
Alex Bennée

  reply	other threads:[~2016-02-15 14:52 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-05  9:24 [Qemu-devel] [PATCH 00/12] tests: Introducing docker tests Fam Zheng
2016-02-05  9:24 ` [Qemu-devel] [PATCH 01/12] tests: Add utilities for docker testing Fam Zheng
2016-02-08 21:49   ` John Snow
2016-02-09  2:01     ` Fam Zheng
2016-02-09 23:16       ` John Snow
2016-02-14  5:10         ` Fam Zheng
2016-02-05  9:24 ` [Qemu-devel] [PATCH 02/12] Makefile: Rules " Fam Zheng
2016-02-15 10:06   ` Alex Bennée
2016-02-15 13:52     ` Fam Zheng
2016-02-15 14:13       ` Alex Bennée
2016-02-05  9:24 ` [Qemu-devel] [PATCH 03/12] docker: Add images Fam Zheng
2016-02-15 10:15   ` Alex Bennée
2016-02-15 13:44     ` Fam Zheng
2016-02-15 14:12       ` Alex Bennée
2016-02-05  9:24 ` [Qemu-devel] [PATCH 04/12] docker: Add test runner Fam Zheng
2016-02-15 10:55   ` Alex Bennée
2016-02-15 12:45     ` Alex Bennée
2016-02-15 13:29       ` Fam Zheng
2016-02-15 14:10         ` Alex Bennée
2016-02-16  2:52           ` Fam Zheng
2016-02-16  6:00           ` Fam Zheng
2016-02-16  8:20             ` Alex Bennée
2016-02-05  9:24 ` [Qemu-devel] [PATCH 05/12] docker: Add common.rc Fam Zheng
2016-02-05  9:24 ` [Qemu-devel] [PATCH 06/12] docker: Add basic test Fam Zheng
2016-02-15 14:34   ` Alex Bennée
2016-02-15 14:42     ` Peter Maydell
2016-02-15 14:52       ` Alex Bennée [this message]
2016-02-16  1:15         ` Fam Zheng
2016-02-05  9:24 ` [Qemu-devel] [PATCH 07/12] docker: Add clang test Fam Zheng
2016-02-05  9:24 ` [Qemu-devel] [PATCH 08/12] docker: Add mingw test Fam Zheng
2016-02-05  9:24 ` [Qemu-devel] [PATCH 09/12] docker: Add travis tool Fam Zheng
2016-02-05  9:24 ` [Qemu-devel] [PATCH 10/12] docs: Add text for tests/docker in build-system.txt Fam Zheng
2016-02-05  9:24 ` [Qemu-devel] [PATCH 11/12] .gitignore: Ignore temporary dockerfile Fam Zheng
2016-02-15 14:42   ` Alex Bennée
2016-02-16  2:43     ` Fam Zheng
2016-02-05  9:24 ` [Qemu-devel] [PATCH 12/12] MAINTAINERS: Add tests/docker Fam Zheng
2016-02-15 14:36   ` Alex Bennée
2016-02-10 11:23 ` [Qemu-devel] [PATCH 00/12] tests: Introducing docker tests Alex Bennée
2016-02-14  5:22   ` Fam Zheng
2016-02-15 17:59 ` Alex Bennée
2016-02-16  2:42   ` Fam Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87si0um3fc.fsf@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=david@gibson.dropbear.id.au \
    --cc=famz@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=sw@weilnetz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).