From: "Alex Bennée" <alex.bennee@linaro.org>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: "Fam Zheng" <fam@euphon.net>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Thomas Huth" <thuth@redhat.com>,
qemu-devel@nongnu.org,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Willian Rampazzo" <willianr@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: Re: [PATCH v4 11/22] tests/docker: expand centos8 package list
Date: Tue, 06 Jul 2021 09:20:00 +0100 [thread overview]
Message-ID: <87tul7ua4g.fsf@linaro.org> (raw)
In-Reply-To: <YON9ca/hOUubkdi9@redhat.com>
Daniel P. Berrangé <berrange@redhat.com> writes:
> On Mon, Jul 05, 2021 at 10:41:55PM +0100, Daniel P. Berrangé wrote:
>> On Mon, Jul 05, 2021 at 09:27:56PM +0100, Alex Bennée wrote:
>> >
>> > Daniel P. Berrangé <berrange@redhat.com> writes:
>> >
>> > > This is the fully expanded list of build pre-requisites QEMU can
>> > > conceivably use in any scenario.
>> > >
>> > > Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> > > Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
>> > > ---
>> > > tests/docker/dockerfiles/centos8.docker | 68 +++++++++++++++++++++++++
>> > > 1 file changed, 68 insertions(+)
>> > >
>> > > diff --git a/tests/docker/dockerfiles/centos8.docker b/tests/docker/dockerfiles/centos8.docker
>> > > index 5f1c57b4ad..4cc4c0c8a1 100644
>> > > --- a/tests/docker/dockerfiles/centos8.docker
>> > > +++ b/tests/docker/dockerfiles/centos8.docker
>> > > @@ -3,36 +3,104 @@ FROM docker.io/centos:8
>> > > RUN dnf -y update
>> > > ENV PACKAGES \
>> > > SDL2-devel \
>> > > + alsa-lib-devel \
>> > > + bc \
>> > > + brlapi-devel \
>> > > bzip2 \
>> > > bzip2-devel \
>> > > + ca-certificates \
>> > > + capstone-devel \
>> >
>> > CentOS8 doesn't seem to package capstone-devel or is it meant to come
>> > from somewhere else?
>>
>> It comes in via the EPEL repository, along with a few other of the
>> packages listed here. Take a look at this job, line 1385 onwards:
>>
>> https://gitlab.com/berrange/qemu/-/jobs/1369975075
>
> Oh actually, this is a bisect issue in the series. The EPEL and
> advanced virt repos are only enabled in the later patch in the
> series that converts to lcitool auto-generation.
>
> IOW, this current patch should have gained:
>
> RUN dnf install -y dnf-plugins-core && \
> dnf config-manager --set-enabled powertools && \
> + dnf install -y centos-release-advanced-virtualization && \
> + dnf install -y epel-release && \
> dnf install -y $PACKAGES
OK I'll revert my deletions and fix that up.
>
>
> Regards,
> Daniel
--
Alex Bennée
next prev parent reply other threads:[~2021-07-06 8:21 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-23 14:22 [PATCH v4 00/22] tests/docker: start using libvirt-ci's "lcitool" for dockerfiles Daniel P. Berrangé
2021-06-23 14:22 ` [PATCH v4 01/22] hw/usb/ccid: remove references to NSS Daniel P. Berrangé
2021-06-25 18:11 ` Willian Rampazzo
2021-07-05 10:37 ` Alex Bennée
2021-06-23 14:22 ` [PATCH v4 02/22] tests/docker: don't use BUILDKIT in GitLab either Daniel P. Berrangé
2021-06-25 20:21 ` Willian Rampazzo
2021-06-23 14:22 ` [PATCH v4 03/22] tests/docker: use project specific container registries Daniel P. Berrangé
2021-06-25 20:24 ` Willian Rampazzo
2021-07-05 12:07 ` Alex Bennée
2021-06-23 14:22 ` [PATCH v4 04/22] tests/docker: use explicit docker.io registry Daniel P. Berrangé
2021-07-05 13:33 ` Alex Bennée
2021-06-23 14:22 ` [PATCH v4 05/22] tests/docker: remove FEATURES env var from templates Daniel P. Berrangé
2021-06-25 20:51 ` Willian Rampazzo
2021-07-05 12:20 ` Alex Bennée
2021-07-05 12:36 ` Alex Bennée
2021-06-23 14:22 ` [PATCH v4 06/22] tests/docker: fix sorting in package lists Daniel P. Berrangé
2021-07-05 13:33 ` Alex Bennée
2021-06-23 14:22 ` [PATCH v4 07/22] tests/docker: fix mistakes in centos " Daniel P. Berrangé
2021-07-05 13:33 ` Alex Bennée
2021-06-23 14:22 ` [PATCH v4 08/22] tests/docker: fix mistakes in fedora package list Daniel P. Berrangé
2021-07-05 13:36 ` Alex Bennée
2021-06-23 14:22 ` [PATCH v4 09/22] tests/docker: fix mistakes in ubuntu package lists Daniel P. Berrangé
2021-07-05 13:40 ` Alex Bennée
2021-06-23 14:22 ` [PATCH v4 10/22] tests/docker: remove mingw packages from Fedora Daniel P. Berrangé
2021-07-05 13:40 ` Alex Bennée
2021-06-23 14:22 ` [PATCH v4 11/22] tests/docker: expand centos8 package list Daniel P. Berrangé
2021-07-05 13:40 ` Alex Bennée
2021-07-05 20:27 ` Alex Bennée
2021-07-05 21:41 ` Daniel P. Berrangé
2021-07-05 21:45 ` Daniel P. Berrangé
2021-07-06 8:20 ` Alex Bennée [this message]
2021-06-23 14:22 ` [PATCH v4 12/22] tests/docker: expand fedora " Daniel P. Berrangé
2021-07-05 13:41 ` Alex Bennée
2021-06-23 14:22 ` [PATCH v4 13/22] tests/docker: expand ubuntu1804 " Daniel P. Berrangé
2021-07-05 13:41 ` Alex Bennée
2021-06-23 14:22 ` [PATCH v4 14/22] tests/docker: expand ubuntu2004 " Daniel P. Berrangé
2021-07-05 13:42 ` Alex Bennée
2021-06-23 14:22 ` [PATCH v4 15/22] tests/docker: expand opensuse-leap " Daniel P. Berrangé
2021-07-05 13:42 ` Alex Bennée
2021-06-23 14:22 ` [PATCH v4 16/22] tests/docker: add script for automating container refresh Daniel P. Berrangé
2021-07-05 13:44 ` Alex Bennée
2021-07-05 14:56 ` Daniel P. Berrangé
2021-07-05 15:26 ` Alex Bennée
2021-06-23 14:22 ` [PATCH v4 17/22] tests/docker: auto-generate centos8 with lcitool Daniel P. Berrangé
2021-06-23 14:22 ` [PATCH v4 18/22] tests/docker: auto-generate fedora " Daniel P. Berrangé
2021-06-23 14:22 ` [PATCH v4 19/22] tests/docker: auto-generate ubuntu1804 " Daniel P. Berrangé
2021-06-23 14:22 ` [PATCH v4 20/22] tests/docker: auto-generate ubuntu2004 " Daniel P. Berrangé
2021-06-23 14:28 ` [PATCH v4 21/22] tests/docker: auto-generate opensuse-leap " Daniel P. Berrangé
2021-06-23 14:29 ` [PATCH v4 22/22] tests/docker: remove ubuntu container Daniel P. Berrangé
2021-06-23 14:42 ` [PATCH v4 00/22] tests/docker: start using libvirt-ci's "lcitool" for dockerfiles no-reply
2021-07-05 14:51 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tul7ua4g.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=berrange@redhat.com \
--cc=f4bug@amsat.org \
--cc=fam@euphon.net \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
--cc=wainersm@redhat.com \
--cc=willianr@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).