From: Markus Armbruster <armbru@redhat.com>
To: Laurent Vivier <lvivier@redhat.com>
Cc: "Daniel P.Berrangé" <berrange@redhat.com>,
"Kashyap Chamarthy" <kchamart@redhat.com>,
"Amit Shah" <amit@kernel.org>,
"Richard Henderson" <richard.henderson@linaro.org>,
qemu-devel@nongnu.org,
"Richard W . M . Jones" <rjones@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v7 0/4] rng-builtin: add an RNG backend that uses qemu_guest_getrandom()
Date: Wed, 05 Jun 2019 19:56:41 +0200 [thread overview]
Message-ID: <87v9xjlxuu.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <4601cfa8-732a-3063-7106-da8d3b990410@redhat.com> (Laurent Vivier's message of "Wed, 5 Jun 2019 15:58:29 +0200")
Laurent Vivier <lvivier@redhat.com> writes:
> On 05/06/2019 15:05, Markus Armbruster wrote:
>> Laurent Vivier <lvivier@redhat.com> writes:
>>
>>> Add a new RNG backend using QEMU builtin getrandom function.
>>>
>>> v7: rebase on master
>>> Make rng-builtin asynchronous with QEMUBH (removed existing R-b)
>>
>> Pardon the ignorant question: why is that necessary?
>>
>
> Because request_entropy() function is called while the request is not in
> the requests queue, so the loop on !QSIMPLEQ_EMPTY(&s->parent.requests)
> doens't process it. The request is added just after the call.
In rng_backend_request_entropy(). I see. Any particular reason for
this order? "I don't know" is an acceptable answer :)
next prev parent reply other threads:[~2019-06-05 17:57 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-29 14:31 [Qemu-devel] [PATCH v7 0/4] rng-builtin: add an RNG backend that uses qemu_guest_getrandom() Laurent Vivier
2019-05-29 14:31 ` [Qemu-devel] [PATCH v7 1/4] VirtIO-RNG: Update default entropy source to `/dev/urandom` Laurent Vivier
2019-06-26 20:29 ` Laurent Vivier
2019-07-02 7:41 ` Laurent Vivier
2019-07-03 14:26 ` Philippe Mathieu-Daudé
2019-05-29 14:31 ` [Qemu-devel] [PATCH v7 2/4] rng-builtin: add an RNG backend that uses qemu_guest_getrandom() Laurent Vivier
2019-06-06 4:46 ` Markus Armbruster
2019-05-29 14:31 ` [Qemu-devel] [PATCH v7 3/4] virtio-rng: Keep the default backend out of VirtIORNGConf Laurent Vivier
2019-05-29 14:31 ` [Qemu-devel] [PATCH v7 4/4] virtio-rng: change default backend to rng-builtin Laurent Vivier
2019-06-05 13:05 ` [Qemu-devel] [PATCH v7 0/4] rng-builtin: add an RNG backend that uses qemu_guest_getrandom() Markus Armbruster
2019-06-05 13:58 ` Laurent Vivier
2019-06-05 17:56 ` Markus Armbruster [this message]
2019-06-05 18:36 ` Laurent Vivier
2019-06-06 4:45 ` Markus Armbruster
2019-06-11 8:42 ` Laurent Vivier
2019-06-17 12:09 ` Laurent Vivier
2019-07-02 13:21 ` Michael S. Tsirkin
2019-07-02 16:48 ` Laurent Vivier
2019-07-03 14:23 ` Amit Shah
2019-07-03 14:57 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v9xjlxuu.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=amit@kernel.org \
--cc=berrange@redhat.com \
--cc=kchamart@redhat.com \
--cc=lvivier@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=rjones@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).