Re: [Qemu-devel] [PATCH v23 22/22] target/rx: remove unused functions.

[Yoshinori Sato <ysato@users.sourceforge.jp>]

On Wed, 21 Aug 2019 19:23:09 +0900,
Philippe Mathieu-Daudé wrote:
> 
> On 8/17/19 9:36 AM, Yoshinori Sato wrote:
> > Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp>
> > ---
> >  target/rx/monitor.c     | 38 --------------------------------------
> >  target/rx/Makefile.objs |  1 -
> >  2 files changed, 39 deletions(-)
> >  delete mode 100644 target/rx/monitor.c
> > 
> > diff --git a/target/rx/monitor.c b/target/rx/monitor.c
> > deleted file mode 100644
> > index 5d7a1e58b5..0000000000
> > --- a/target/rx/monitor.c
> > +++ /dev/null
> 
> Why not squash it in your patch #06 "target/rx: CPU definition"?
> 
> If you are OK with this suggestion and there is no more comment on this
> series, the maintainer willing to take your series can probably do that
> for you (no need to repost!).

Oh. I forgot this changes.
There are currently no issues with this series.

> > @@ -1,38 +0,0 @@
> > -/*
> > - * QEMU monitor
> > - *
> > - * Copyright (c) 2003-2004 Fabrice Bellard
> > - *
> > - * Permission is hereby granted, free of charge, to any person obtaining a copy
> > - * of this software and associated documentation files (the "Software"), to deal
> > - * in the Software without restriction, including without limitation the rights
> > - * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
> > - * copies of the Software, and to permit persons to whom the Software is
> > - * furnished to do so, subject to the following conditions:
> > - *
> > - * The above copyright notice and this permission notice shall be included in
> > - * all copies or substantial portions of the Software.
> > - *
> > - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
> > - * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> > - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
> > - * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
> > - * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
> > - * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
> > - * THE SOFTWARE.
> > - */
> > -#include "qemu/osdep.h"
> > -#include "cpu.h"
> > -#include "monitor/monitor.h"
> > -#include "monitor/hmp-target.h"
> > -#include "hmp.h"
> > -
> > -void hmp_info_tlb(Monitor *mon, const QDict *qdict)
> > -{
> > -    CPUArchState *env = mon_get_cpu_env();
> > -
> > -    if (!env) {
> > -        monitor_printf(mon, "No CPU available\n");
> > -        return;
> > -    }
> > -}
> > diff --git a/target/rx/Makefile.objs b/target/rx/Makefile.objs
> > index aa6f2d2d6c..a0018d5bc5 100644
> > --- a/target/rx/Makefile.objs
> > +++ b/target/rx/Makefile.objs
> > @@ -1,5 +1,4 @@
> >  obj-y += translate.o op_helper.o helper.o cpu.o gdbstub.o disas.o
> > -obj-$(CONFIG_SOFTMMU) += monitor.o
> >  
> >  DECODETREE = $(SRC_PATH)/scripts/decodetree.py
> >  
> > 

-- 
Yosinori Sato