[dropping non-qemu lists] On 8/23/19 9:37 AM, Eric Blake wrote: > A server may have a reason to reject a request for structured replies, > beyond just not recognizing them as a valid request. It doesn't hurt > us to continue talking to such a server; otherwise 'qemu-nbd --list' > of such a server fails to display all possible details about the > export. > > Encountered when temporarily tweaking nbdkit to reply with > NBD_REP_ERR_POLICY. Present since structured reply support was first > added (commit d795299b reused starttls handling, but starttls has to > reject all errors). > > Signed-off-by: Eric Blake > --- > nbd/client.c | 39 +++++++++++++++++++++++---------------- > 1 file changed, 23 insertions(+), 16 deletions(-) Shoot, I included one patch too many. This patch was posted in a separate thread, where I argued that it is broken and needs a v2: https://lists.gnu.org/archive/html/qemu-devel/2019-08/msg04323.html -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org