From: Auger Eric <eric.auger@redhat.com>
To: Zenghui Yu <yuzenghui@huawei.com>
Cc: peter.maydell@linaro.org, drjones@redhat.com,
kvm@vger.kernel.org, maz@kernel.org, qemu-devel@nongnu.org,
qemu-arm@nongnu.org, andre.przywara@arm.com, thuth@redhat.com,
alexandru.elisei@arm.com, kvmarm@lists.cs.columbia.edu,
eric.auger.pro@gmail.com
Subject: Re: [kvm-unit-tests PATCH v7 06/13] arm/arm64: ITS: Introspection tests
Date: Mon, 30 Mar 2020 10:46:57 +0200 [thread overview]
Message-ID: <8878be7f-7653-b427-cd0d-722f82fb6b65@redhat.com> (raw)
In-Reply-To: <947a79f5-1f79-532b-9ec7-6fd539ccd183@huawei.com>
Hi Zenghui,
On 3/30/20 10:30 AM, Zenghui Yu wrote:
> Hi Eric,
>
> On 2020/3/20 17:24, Eric Auger wrote:
>> +static void its_cmd_queue_init(void)
>> +{
>> + unsigned long order = get_order(SZ_64K >> PAGE_SHIFT);
>> + u64 cbaser;
>> +
>> + its_data.cmd_base = (void *)virt_to_phys(alloc_pages(order));
>
> Shouldn't the cmd_base (and the cmd_write) be set as a GVA?
yes it should
>
> Otherwise I think we will end-up with memory corruption when writing
> the command queue. But it seems that everything just works fine ...
> So I'm really confused here :-/
I was told by Paolo that the VA/PA memory map is flat in kvmunit test.
>
>> +
>> + cbaser = ((u64)its_data.cmd_base | (SZ_64K / SZ_4K - 1) |
>> GITS_CBASER_VALID);
>> +
>> + writeq(cbaser, its_data.base + GITS_CBASER);
>> +
>> + its_data.cmd_write = its_data.cmd_base;
>> + writeq(0, its_data.base + GITS_CWRITER);
>> +}
>
> Otherwise this looks good,
> Reviewed-by: Zenghui Yu <yuzenghui@huawei.com>
Thanks!
Eric
>
>
> Thanks
>
next prev parent reply other threads:[~2020-03-30 8:49 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-20 9:24 [kvm-unit-tests PATCH v7 00/13] arm/arm64: Add ITS tests Eric Auger
2020-03-20 9:24 ` [kvm-unit-tests PATCH v7 01/13] libcflat: Add other size defines Eric Auger
2020-03-20 9:24 ` [kvm-unit-tests PATCH v7 02/13] page_alloc: Introduce get_order() Eric Auger
2020-03-20 9:24 ` [kvm-unit-tests PATCH v7 03/13] arm/arm64: gic: Introduce setup_irq() helper Eric Auger
2020-03-20 9:24 ` [kvm-unit-tests PATCH v7 04/13] arm/arm64: gicv3: Add some re-distributor defines Eric Auger
2020-03-20 9:24 ` [kvm-unit-tests PATCH v7 05/13] arm/arm64: gicv3: Set the LPI config and pending tables Eric Auger
2020-03-20 9:24 ` [kvm-unit-tests PATCH v7 06/13] arm/arm64: ITS: Introspection tests Eric Auger
2020-03-30 8:30 ` Zenghui Yu
2020-03-30 8:46 ` Auger Eric [this message]
2020-03-30 9:11 ` Andrew Jones
2020-03-30 9:56 ` Auger Eric
2020-03-30 10:19 ` Andrew Jones
2020-03-30 10:24 ` Auger Eric
2020-03-30 12:20 ` Zenghui Yu
2020-03-20 9:24 ` [kvm-unit-tests PATCH v7 07/13] arm/arm64: ITS: its_enable_defaults Eric Auger
2020-03-20 9:24 ` [kvm-unit-tests PATCH v7 08/13] arm/arm64: ITS: Device and collection Initialization Eric Auger
2020-03-25 8:10 ` Zenghui Yu
2020-03-25 21:20 ` Auger Eric
2020-03-30 9:13 ` Andrew Jones
2020-03-20 9:24 ` [kvm-unit-tests PATCH v7 09/13] arm/arm64: ITS: Commands Eric Auger
2020-03-30 9:22 ` Zenghui Yu
2020-03-30 9:57 ` Auger Eric
2020-03-20 9:24 ` [kvm-unit-tests PATCH v7 10/13] arm/arm64: ITS: INT functional tests Eric Auger
2020-03-30 10:43 ` Zenghui Yu
2020-04-02 8:50 ` Auger Eric
2020-04-02 12:40 ` Zenghui Yu
2020-04-02 14:41 ` Andrew Jones
2020-03-20 9:24 ` [kvm-unit-tests PATCH v7 11/13] arm/run: Allow Migration tests Eric Auger
2020-03-20 9:24 ` [kvm-unit-tests PATCH v7 12/13] arm/arm64: ITS: migration tests Eric Auger
2020-03-30 10:55 ` Zenghui Yu
2020-03-20 9:24 ` [kvm-unit-tests PATCH v7 13/13] arm/arm64: ITS: pending table migration test Eric Auger
2020-03-30 12:06 ` Zenghui Yu
2020-03-30 12:38 ` Auger Eric
2020-03-30 13:17 ` Zenghui Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8878be7f-7653-b427-cd0d-722f82fb6b65@redhat.com \
--to=eric.auger@redhat.com \
--cc=alexandru.elisei@arm.com \
--cc=andre.przywara@arm.com \
--cc=drjones@redhat.com \
--cc=eric.auger.pro@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=maz@kernel.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).