From: John Snow <jsnow@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>, qemu-devel@nongnu.org
Cc: "Fam Zheng" <fam@euphon.net>, "Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [PATCH 3/3] docker: remove unused debian-sid and debian-ports
Date: Mon, 23 Sep 2019 13:22:34 -0400 [thread overview]
Message-ID: <8b228b95-fd6e-ffd0-0750-bc651a63fbd2@redhat.com> (raw)
In-Reply-To: <03273f50-3146-328c-fe7c-e437d7b65e0a@redhat.com>
On 9/21/19 5:53 AM, Philippe Mathieu-Daudé wrote:
> Hi John,
>
> On 9/20/19 2:14 AM, John Snow wrote:
>> These are listed as "partial" images, but have no user.
>> Remove them.
>>
>> Signed-off-by: John Snow <jsnow@redhat.com>
>> ---
>> tests/docker/Makefile.include | 4 +--
>> tests/docker/dockerfiles/debian-ports.docker | 36 --------------------
>> tests/docker/dockerfiles/debian-sid.docker | 35 -------------------
>> 3 files changed, 2 insertions(+), 73 deletions(-)
>> delete mode 100644 tests/docker/dockerfiles/debian-ports.docker
>> delete mode 100644 tests/docker/dockerfiles/debian-sid.docker
>
> Can you split this patch in 2, one per image? That will ease the reverts.
>
> Once splitted feel free to add to each new patch:
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>
> Thanks,
>
> Phil.
>
Sounds good to me, thanks!
prev parent reply other threads:[~2019-09-23 17:23 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-20 0:14 [PATCH 0/3] docker: misc cleanups John Snow
2019-09-20 0:14 ` [PATCH 1/3] docker: remove 'deprecated' image definitions John Snow
2019-09-20 0:14 ` [PATCH 2/3] docker: remove debian8-mxe definitions John Snow
2019-09-20 0:14 ` [PATCH 3/3] docker: remove unused debian-sid and debian-ports John Snow
2019-09-20 8:49 ` Philippe Mathieu-Daudé
2019-09-20 16:10 ` John Snow
2019-09-20 16:20 ` Alex Bennée
2019-09-20 16:23 ` Philippe Mathieu-Daudé
2019-09-20 16:28 ` Philippe Mathieu-Daudé
2019-09-20 17:34 ` John Snow
2019-09-20 16:30 ` Alex Bennée
2019-09-20 17:24 ` John Snow
2019-09-20 21:19 ` Alex Bennée
2019-09-20 21:32 ` John Snow
2019-09-21 9:53 ` Philippe Mathieu-Daudé
2019-09-23 17:22 ` John Snow [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b228b95-fd6e-ffd0-0750-bc651a63fbd2@redhat.com \
--to=jsnow@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=fam@euphon.net \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).