From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: Alistair Francis <alistair.francis@opensource.wdc.com>,
qemu-devel@nongnu.org, qemu-riscv@nongnu.org
Cc: alistair.francis@wdc.com, bmeng.cn@gmail.com, palmer@dabbelt.com,
alistair23@gmail.com
Subject: Re: [PATCH v1 1/1] hw/riscv: shakti_c: Mark as not user creatable
Date: Mon, 27 Sep 2021 17:35:01 +0200 [thread overview]
Message-ID: <8e03f4a4-a47e-5e89-795a-d6d331c88cbf@amsat.org> (raw)
In-Reply-To: <bc032f02f44192bfa057cc4f09311fd18d07ef1f.1632726758.git.alistair.francis@wdc.com>
Hi Alistair,
On 9/27/21 09:13, Alistair Francis wrote:
> From: Alistair Francis <alistair.francis@wdc.com>
>
> Mark the shakti_c machine as not user creatable as it uses serial_hd.
>
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/639
> Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
> ---
> hw/riscv/shakti_c.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/hw/riscv/shakti_c.c b/hw/riscv/shakti_c.c
> index 2f084d3c8d..603992d442 100644
> --- a/hw/riscv/shakti_c.c
> +++ b/hw/riscv/shakti_c.c
> @@ -150,6 +150,8 @@ static void shakti_c_soc_class_init(ObjectClass *klass, void *data)
> {
> DeviceClass *dc = DEVICE_CLASS(klass);
> dc->realize = shakti_c_soc_state_realize;
> + /* Reason: Uses serial_hds in realize function, thus can't be used twice */
> + dc->user_creatable = false;
I agree with the logical change, but not totally with the comment.
Well, the comment itself is not incorrect. But the error happens before:
ERROR:tcg/tcg.c:479:tcg_register_thread: assertion failed: (n <
tcg_max_ctxs)
The reason is TYPE_RISCV_HART_ARRAY creates CPUs in
riscv_hart_realize(), and this machine use the default CPU limit
of one CPU:
static void shakti_c_machine_class_init(ObjectClass *klass, void *data)
{
MachineClass *mc = MACHINE_CLASS(klass);
mc->desc = "RISC-V Board compatible with Shakti SDK";
mc->init = shakti_c_machine_state_init;
mc->default_cpu_type = TYPE_RISCV_CPU_SHAKTI_C;
}
The default values come from:
static void machine_class_base_init(ObjectClass *oc, void *data)
{
MachineClass *mc = MACHINE_CLASS(oc);
mc->max_cpus = mc->max_cpus ?: 1;
mc->min_cpus = mc->min_cpus ?: 1;
mc->default_cpus = mc->default_cpus ?: 1;
So the crash happens when we try to create the 2nd CPU.
> }
>
> static void shakti_c_soc_instance_init(Object *obj)
>
prev parent reply other threads:[~2021-09-27 15:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-27 7:13 [PATCH v1 1/1] hw/riscv: shakti_c: Mark as not user creatable Alistair Francis
2021-09-27 7:27 ` Bin Meng
2021-09-27 15:35 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e03f4a4-a47e-5e89-795a-d6d331c88cbf@amsat.org \
--to=f4bug@amsat.org \
--cc=alistair.francis@opensource.wdc.com \
--cc=alistair.francis@wdc.com \
--cc=alistair23@gmail.com \
--cc=bmeng.cn@gmail.com \
--cc=palmer@dabbelt.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).