From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: Valeriy Vdovin <valeriy.vdovin@virtuozzo.com>
Cc: qemu-devel@nongnu.org, Eric Blake <eblake@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
Eduardo Habkost <ehabkost@redhat.com>,
Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>,
Denis Lunev <den@openvz.org>
Subject: Re: [PATCH v2] qapi: introduce 'query-cpu-model-cpuid' action
Date: Fri, 26 Mar 2021 18:29:37 +0300 [thread overview]
Message-ID: <8f71d585-fc25-0301-620a-20c4e621d009@virtuozzo.com> (raw)
In-Reply-To: <20210326151808.GC97643@dhcp-172-16-24-191.sw.ru>
26.03.2021 18:18, Valeriy Vdovin wrote:
>> Also, we have implementation of qmp_query_cpu_* commands in different architectures.. Probably we'll need add some stubs for the new command as well.
>>
> Currently I do not have a clear idea of how we could do this, because cpuid is very specific to x86. Other cpu architectures also have cpu
> identification means that could be close to x86 cpuid, but not as close to easily generalize this method. But I'm willing to hear out a
> good advice on this topic.
>
I mean, that I'm afraid, that after your patch QEMU will not compile for other architectures, as it will say "no such qmp_query_model_cpuid function". Probably I'm wrong. If I'm right, we'll need a stub implementation for other architectures, like
qmp_query_model_cpuid(Error **errp)
{
error_setg(errp, "Not implemented");
}
--
Best regards,
Vladimir
next prev parent reply other threads:[~2021-03-26 15:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-25 16:57 [PATCH v2] qapi: introduce 'query-cpu-model-cpuid' action Valeriy Vdovin
2021-03-26 10:01 ` Vladimir Sementsov-Ogievskiy
2021-03-26 15:18 ` Valeriy Vdovin
2021-03-26 15:29 ` Vladimir Sementsov-Ogievskiy [this message]
2021-03-30 0:15 ` Igor Mammedov
2021-03-30 9:37 ` Valeriy Vdovin
2021-03-31 9:19 ` Igor Mammedov
2021-04-02 18:46 ` Valeriy Vdovin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f71d585-fc25-0301-620a-20c4e621d009@virtuozzo.com \
--to=vsementsov@virtuozzo.com \
--cc=armbru@redhat.com \
--cc=den@openvz.org \
--cc=eblake@redhat.com \
--cc=ehabkost@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=valeriy.vdovin@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).