qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@web.de>
To: qemu-devel <qemu-devel@nongnu.org>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Richard Henderson <rth@twiddle.net>,
	Eduardo Habkost <ehabkost@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] i386/vmmouse: Properly reset state
Date: Sun, 25 Aug 2019 16:58:18 +0200	[thread overview]
Message-ID: <90ea3127-5e26-ed2a-4ad7-d30445bcf53a@web.de> (raw)
In-Reply-To: <f056c7e5-fa74-469c-87f8-0f0925301b2d@web.de>

On 21.07.19 10:58, Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
>
> nb_queue was not zeroed so that we no longer delivered events if a
> previous guest left the device in an overflow state.
>
> The state of absolute does not matter as the next vmmouse_update_handler
> call will align it again.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>   hw/i386/vmmouse.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/hw/i386/vmmouse.c b/hw/i386/vmmouse.c
> index 5d2d278be4..e335bd07da 100644
> --- a/hw/i386/vmmouse.c
> +++ b/hw/i386/vmmouse.c
> @@ -257,6 +257,7 @@ static void vmmouse_reset(DeviceState *d)
>       VMMouseState *s = VMMOUSE(d);
>
>       s->queue_size = VMMOUSE_QUEUE_SIZE;
> +    s->nb_queue = 0;
>
>       vmmouse_disable(s);
>   }
> --
> 2.16.4
>
>

Ping - or who is looking after this?

Jan


  reply	other threads:[~2019-08-25 15:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-21  8:58 [Qemu-devel] [PATCH] i386/vmmouse: Properly reset state Jan Kiszka
2019-08-25 14:58 ` Jan Kiszka [this message]
2019-08-27 19:49   ` Eduardo Habkost
2019-08-29 18:00     ` Philippe Mathieu-Daudé
2019-08-29 18:12       ` Jan Kiszka
2019-08-29 18:38         ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=90ea3127-5e26-ed2a-4ad7-d30445bcf53a@web.de \
    --to=jan.kiszka@web.de \
    --cc=ehabkost@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).