From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18ED1C433C1 for ; Tue, 23 Mar 2021 14:01:04 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 97EA061992 for ; Tue, 23 Mar 2021 14:01:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 97EA061992 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:36986 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lOhag-0002Eu-Ah for qemu-devel@archiver.kernel.org; Tue, 23 Mar 2021 10:01:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37544) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lOhYb-0007gS-4F for qemu-devel@nongnu.org; Tue, 23 Mar 2021 09:58:53 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:42766) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lOhYU-0007k5-N5 for qemu-devel@nongnu.org; Tue, 23 Mar 2021 09:58:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1616507925; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oK+JV6C276KJ1Q/h5K3Y+bDuuEFFOB3JfHBow1IL/TQ=; b=f0e3pGxiyfa+o1eMIr4GT3RLKoBJvp5levp8fVwtwtsepfqt7vE51UNSBNdL4Zi9k6AFXv sM7BuBawyf6X7oeI97dPHA88bWOa93/oR1Hr3zb5O74xX9gRD4K1eCfTjLxz0GHTp6P5XR P4uMNPshhJrqdtzUtjK0oJGyfbtv2J4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-192-gIsVHylHP6C13y4gj_O4kg-1; Tue, 23 Mar 2021 09:58:42 -0400 X-MC-Unique: gIsVHylHP6C13y4gj_O4kg-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C0683107ACCD; Tue, 23 Mar 2021 13:58:41 +0000 (UTC) Received: from [10.3.112.201] (ovpn-112-201.phx2.redhat.com [10.3.112.201]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5690C19C45; Tue, 23 Mar 2021 13:58:37 +0000 (UTC) To: John Snow , Markus Armbruster , qemu-devel@nongnu.org References: <20210323094025.3569441-1-armbru@redhat.com> <20210323094025.3569441-4-armbru@redhat.com> <323d8fd2-56e0-db29-e2c8-0d71bea9d81d@redhat.com> From: Eric Blake Organization: Red Hat, Inc. Subject: Re: [PATCH 03/28] tests/qapi-schema: Rework comments on longhand member definitions Message-ID: <914fd5f6-9369-8bea-758d-be134f4a3f4a@redhat.com> Date: Tue, 23 Mar 2021 08:58:37 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <323d8fd2-56e0-db29-e2c8-0d71bea9d81d@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=eblake@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=eblake@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: michael.roth@amd.com, marcandre.lureau@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 3/23/21 8:00 AM, John Snow wrote: > On 3/23/21 5:40 AM, Markus Armbruster wrote: >> +# event 'data' member with dict value is (longhand) argument >> +# definition, not inline complex type > > I have to be a weenie and say I don't know exactly what this comment is > telling me. > > (1) What's a longhand argument? Writing { 'type':'str', 'name':'foo' } is longhand for the corresponding 'foo':'str' shorthand. > (2) What's an inline complex type? Writing { 'command':'Foo', 'returns': { 'foo':'str' } } or { 'union':'U', 'base': { 'foo':'Enum' } ... } are inline complex types; they are shorthand for: { 'struct':'FooReturn', 'data': { 'foo':'str' } } { 'struct':'UBase', 'data': { 'foo':'Enum' } } { 'command':'Foo', 'returns':'FooReturn' } { 'union':'U', 'base':'UBase' } At one point, I had the idea that we might want to write: { 'union':'U', ... 'data': { 'branch': { inline type } } } instead of having to pre-declare the type for the branch; but that idea is no longer feasible, since it would be awkward to distinguish from what we DO have of: { 'union':'U', ... 'data': { 'branch': { 'type':'Branch', 'if': 'COND' } } } and where I don't really see us wanting: { 'union':U', ... 'data': { 'branch': { 'type': { inline type }, 'if': 'COND' } } } (If the situation changes and we do want anonymous inline types anywhere a name can appear now, we'll have more work to do) -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org