qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Krempa <pkrempa@redhat.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
	Markus Armbruster <armbru@redhat.com>,
	Michael Roth <mdroth@linux.vnet.ibm.com>
Subject: [PATCH v2 2/2] qapi: Allow introspecting fix for savevm's cooperation with blockdev
Date: Fri, 20 Sep 2019 16:26:45 +0200	[thread overview]
Message-ID: <992ea9ca130b4fb6dbf82726aa3b1d8040c16944.1568989362.git.pkrempa@redhat.com> (raw)
In-Reply-To: <cover.1568989362.git.pkrempa@redhat.com>

savevm was buggy as it considered all monitor owned block device nodes
for snapshot. With introduction of -blockdev the common usage made all
nodes including protocol nodes monitor owned and thus considered for
snapshot. This was fixed but clients need to be able to detect whether
this fix is present.

Since savevm does not have an QMP alternative add the feature for the
'human-monitor-command' backdoor which is used to call this command in
modern use.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 qapi/misc.json | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/qapi/misc.json b/qapi/misc.json
index 6bd11f50e6..673445dfa9 100644
--- a/qapi/misc.json
+++ b/qapi/misc.json
@@ -1020,6 +1020,12 @@
 #
 # @cpu-index: The CPU to use for commands that require an implicit CPU
 #
+# Features:
+# @savevm-blockdev-monitor-nodes: If present, the savevm monitor command only
+#                                 snapshots monitor owned nodes if they have no
+#                                 parents. This allows to use 'savevm' with
+#                                 -blockdev. (since 4.2)
+#
 # Returns: the output of the command as a string
 #
 # Since: 0.14.0
@@ -1047,7 +1053,8 @@
 ##
 { 'command': 'human-monitor-command',
   'data': {'command-line': 'str', '*cpu-index': 'int'},
-  'returns': 'str' }
+  'returns': 'str',
+  'features' : [ { 'name': 'savevm-blockdev-monitor-nodes' } ] }

 ##
 # @change:
-- 
2.21.0



  parent reply	other threads:[~2019-09-20 14:39 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-20 14:26 [PATCH v2 0/2] qapi: Add detection for the 'savevm' fix for blockdev Peter Krempa
2019-09-20 14:26 ` [PATCH v2 1/2] qapi: Add feature flags to commands in qapi introspection Peter Krempa
2019-10-01  6:40   ` Markus Armbruster
2019-10-01 14:17     ` Peter Krempa
2019-10-01 20:01   ` Markus Armbruster
2019-10-02  6:15     ` Markus Armbruster
2019-09-20 14:26 ` Peter Krempa [this message]
2019-10-01 19:34   ` [PATCH v2 2/2] qapi: Allow introspecting fix for savevm's cooperation with blockdev Markus Armbruster
2019-10-01 21:07     ` Eric Blake
2019-10-02 11:57       ` Markus Armbruster
2019-10-10 15:07         ` Kevin Wolf
2019-10-11  6:08           ` Markus Armbruster
2019-10-11  9:00             ` Kevin Wolf
2019-10-11 11:10               ` Markus Armbruster
2019-09-30 13:04 ` [PATCH v2 0/2] qapi: Add detection for the 'savevm' fix for blockdev Peter Krempa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=992ea9ca130b4fb6dbf82726aa3b1d8040c16944.1568989362.git.pkrempa@redhat.com \
    --to=pkrempa@redhat.com \
    --cc=armbru@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).