From: Paolo Bonzini <pbonzini@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>, qemu-devel@nongnu.org
Cc: Yang Zhong <yang.zhong@intel.com>,
Samuel Ortiz <sameo@linux.intel.com>,
Rob Bradford <robert.bradford@intel.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
kvm@vger.kernel.org, Christophe de Dinechin <dinechin@redhat.com>,
Richard Henderson <rth@twiddle.net>,
Eduardo Habkost <ehabkost@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v4 00/15] hw/i386/pc: Do not restrict the fw_cfg functions to the PC machine
Date: Thu, 22 Aug 2019 12:28:35 +0200 [thread overview]
Message-ID: <9e7a5fa2-2bf7-f3fe-57d9-680498166bf9@redhat.com> (raw)
In-Reply-To: <20190818225414.22590-1-philmd@redhat.com>
On 19/08/19 00:53, Philippe Mathieu-Daudé wrote:
> Hi,
>
> This is my take at salvaging some NEMU good work.
> Samuel worked in adding the fw_cfg device to the x86-virt NEMU machine.
> This series is inspired by NEMU's commit 3cb92d080835 [0] and adapted
> to upstream style. The result makes the upstream codebase more
> modularizable.
> There are very little logical changes, this is mostly a cleanup
> refactor.
>
> Since v3 [3]:
> - Addressed Christophe suggestion (patch #8)
> - Rebased patch #15 since Eduardo merged Like Xu's work between.
>
> Since v2 [2]:
> - Addressed MST comments from v2 (only patch #2 modified)
> - do not use unsigned for enum
> - do not add unuseful documentation
>
> Since v1 [1]:
> - Addressed Li and MST comments
>
> $ git backport-diff -u v3
> Key:
> [----] : patches are identical
> [####] : number of functional differences between upstream/downstream patch
> [down] : patch is downstream-only
> The flags [FC] indicate (F)unctional and (C)ontextual differences, respectively
>
> 001/15:[----] [--] 'hw/i386/pc: Use e820_get_num_entries() to access e820_entries'
> 002/15:[----] [-C] 'hw/i386/pc: Extract e820 memory layout code'
> 003/15:[----] [--] 'hw/i386/pc: Use address_space_memory in place'
> 004/15:[----] [-C] 'hw/i386/pc: Rename bochs_bios_init as more generic fw_cfg_arch_create'
> 005/15:[----] [--] 'hw/i386/pc: Pass the boot_cpus value by argument'
> 006/15:[----] [--] 'hw/i386/pc: Pass the apic_id_limit value by argument'
> 007/15:[0002] [FC] 'hw/i386/pc: Pass the CPUArchIdList array by argument'
> 008/15:[down] 'hw/i386/pc: Remove unused PCMachineState argument in fw_cfg_arch_create'
> 009/15:[----] [-C] 'hw/i386/pc: Let pc_build_smbios() take a FWCfgState argument'
> 010/15:[----] [-C] 'hw/i386/pc: Let pc_build_smbios() take a generic MachineState argument'
> 011/15:[----] [-C] 'hw/i386/pc: Rename pc_build_smbios() as generic fw_cfg_build_smbios()'
> 012/15:[----] [--] 'hw/i386/pc: Let pc_build_feature_control() take a FWCfgState argument'
> 013/15:[----] [--] 'hw/i386/pc: Let pc_build_feature_control() take a MachineState argument'
> 014/15:[----] [--] 'hw/i386/pc: Rename pc_build_feature_control() as generic fw_cfg_build_*'
> 015/15:[0017] [FC] 'hw/i386/pc: Extract the x86 generic fw_cfg code'
>
> Regards,
>
> Phil.
>
> [0] https://github.com/intel/nemu/commit/3cb92d080835ac8d47c8b713156338afa33cff5c
> [1] https://lists.gnu.org/archive/html/qemu-devel/2019-05/msg05759.html
> [2] https://lists.gnu.org/archive/html/qemu-devel/2019-06/msg02786.html
> [3] https://lists.gnu.org/archive/html/qemu-devel/2019-07/msg00193.html
>
> Philippe Mathieu-Daudé (15):
> hw/i386/pc: Use e820_get_num_entries() to access e820_entries
> hw/i386/pc: Extract e820 memory layout code
> hw/i386/pc: Use address_space_memory in place
> hw/i386/pc: Rename bochs_bios_init as more generic fw_cfg_arch_create
> hw/i386/pc: Pass the boot_cpus value by argument
> hw/i386/pc: Pass the apic_id_limit value by argument
> hw/i386/pc: Pass the CPUArchIdList array by argument
> hw/i386/pc: Remove unused PCMachineState argument in
> fw_cfg_arch_create
> hw/i386/pc: Let pc_build_smbios() take a FWCfgState argument
> hw/i386/pc: Let pc_build_smbios() take a generic MachineState argument
> hw/i386/pc: Rename pc_build_smbios() as generic fw_cfg_build_smbios()
> hw/i386/pc: Let pc_build_feature_control() take a FWCfgState argument
> hw/i386/pc: Let pc_build_feature_control() take a MachineState
> argument
> hw/i386/pc: Rename pc_build_feature_control() as generic
> fw_cfg_build_*
> hw/i386/pc: Extract the x86 generic fw_cfg code
>
> hw/i386/Makefile.objs | 2 +-
> hw/i386/e820_memory_layout.c | 59 ++++++++++
> hw/i386/e820_memory_layout.h | 42 ++++++++
> hw/i386/fw_cfg.c | 136 +++++++++++++++++++++++
> hw/i386/fw_cfg.h | 7 ++
> hw/i386/pc.c | 202 ++---------------------------------
> include/hw/i386/pc.h | 11 --
> target/i386/kvm.c | 1 +
> 8 files changed, 254 insertions(+), 206 deletions(-)
> create mode 100644 hw/i386/e820_memory_layout.c
> create mode 100644 hw/i386/e820_memory_layout.h
>
Queued, thanks.
Paolo
prev parent reply other threads:[~2019-08-22 10:30 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-18 22:53 [Qemu-devel] [PATCH v4 00/15] hw/i386/pc: Do not restrict the fw_cfg functions to the PC machine Philippe Mathieu-Daudé
2019-08-18 22:54 ` [Qemu-devel] [PATCH v4 01/15] hw/i386/pc: Use e820_get_num_entries() to access e820_entries Philippe Mathieu-Daudé
2019-08-18 22:54 ` [Qemu-devel] [PATCH v4 02/15] hw/i386/pc: Extract e820 memory layout code Philippe Mathieu-Daudé
2019-08-18 22:54 ` [Qemu-devel] [PATCH v4 03/15] hw/i386/pc: Use address_space_memory in place Philippe Mathieu-Daudé
2019-08-18 22:54 ` [Qemu-devel] [PATCH v4 04/15] hw/i386/pc: Rename bochs_bios_init as more generic fw_cfg_arch_create Philippe Mathieu-Daudé
2019-08-18 22:54 ` [Qemu-devel] [PATCH v4 05/15] hw/i386/pc: Pass the boot_cpus value by argument Philippe Mathieu-Daudé
2019-08-18 22:54 ` [Qemu-devel] [PATCH v4 06/15] hw/i386/pc: Pass the apic_id_limit " Philippe Mathieu-Daudé
2019-08-18 22:54 ` [Qemu-devel] [PATCH v4 07/15] hw/i386/pc: Pass the CPUArchIdList array " Philippe Mathieu-Daudé
2019-08-18 22:54 ` [Qemu-devel] [PATCH v4 08/15] hw/i386/pc: Remove unused PCMachineState argument in fw_cfg_arch_create Philippe Mathieu-Daudé
2019-08-18 22:54 ` [Qemu-devel] [PATCH v4 09/15] hw/i386/pc: Let pc_build_smbios() take a FWCfgState argument Philippe Mathieu-Daudé
2019-08-18 22:54 ` [Qemu-devel] [PATCH v4 10/15] hw/i386/pc: Let pc_build_smbios() take a generic MachineState argument Philippe Mathieu-Daudé
2019-08-18 22:54 ` [Qemu-devel] [PATCH v4 11/15] hw/i386/pc: Rename pc_build_smbios() as generic fw_cfg_build_smbios() Philippe Mathieu-Daudé
2019-08-18 22:54 ` [Qemu-devel] [PATCH v4 12/15] hw/i386/pc: Let pc_build_feature_control() take a FWCfgState argument Philippe Mathieu-Daudé
2019-08-18 22:54 ` [Qemu-devel] [PATCH v4 13/15] hw/i386/pc: Let pc_build_feature_control() take a MachineState argument Philippe Mathieu-Daudé
2019-08-18 22:54 ` [Qemu-devel] [PATCH v4 14/15] hw/i386/pc: Rename pc_build_feature_control() as generic fw_cfg_build_* Philippe Mathieu-Daudé
2019-08-18 22:54 ` [Qemu-devel] [PATCH v4 15/15] hw/i386/pc: Extract the x86 generic fw_cfg code Philippe Mathieu-Daudé
2019-08-22 10:28 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e7a5fa2-2bf7-f3fe-57d9-680498166bf9@redhat.com \
--to=pbonzini@redhat.com \
--cc=dinechin@redhat.com \
--cc=ehabkost@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=mtosatti@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=robert.bradford@intel.com \
--cc=rth@twiddle.net \
--cc=sameo@linux.intel.com \
--cc=yang.zhong@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).