From: Anup Patel <anup@brainfault.org>
To: Palmer Dabbelt <palmer@dabbelt.com>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Palmer Dabbelt" <palmer@sifive.com>,
"open list:RISC-V" <qemu-riscv@nongnu.org>,
"Sagar Karandikar" <sagark@eecs.berkeley.edu>,
"Bastian Koppelmann" <kbastian@mail.uni-paderborn.de>,
"Anup Patel" <Anup.Patel@wdc.com>,
"QEMU Developers" <qemu-devel@nongnu.org>,
"Atish Patra" <Atish.Patra@wdc.com>,
"Alistair Francis" <Alistair.Francis@wdc.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: Re: [PATCH v8 0/3] RTC support for QEMU RISC-V virt machine
Date: Wed, 22 Jan 2020 17:13:08 +0530 [thread overview]
Message-ID: <CAAhSdy2QAcRz42uHC+DvBZ5mrzZ8Drz59Ps3_TPKB-8EDeh-uQ@mail.gmail.com> (raw)
In-Reply-To: <mhng-fceb5aa2-7610-421a-b350-d939ace5fee2@palmer-si-x1c4>
On Thu, Nov 7, 2019 at 10:22 PM Palmer Dabbelt <palmer@dabbelt.com> wrote:
>
> On Wed, 06 Nov 2019 03:56:29 PST (-0800), Anup Patel wrote:
> > This series adds RTC device to QEMU RISC-V virt machine. We have
> > selected Goldfish RTC device model for this. It's a pretty simple
> > synthetic device with few MMIO registers and no dependency external
> > clock. The driver for Goldfish RTC is already available in Linux so
> > we just need to enable it in Kconfig for RISCV and also update Linux
> > defconfigs.
> >
> > We have tested this series with Linux-5.4-rc4 plus defconfig changes
> > available in 'goldfish_rtc_v2' branch of:
> > https://github.com/avpatel/linux.git
> >
> > Changes since v7:
> > - Fix broken "stdout-path" in "/chosen" DT node of virt machine
> >
> > Changes since v6:
> > - Rebased on latest QEMU master
> > - Addressed all nit comments from Philippe Mathieu-Daude
> >
> > Changes since v5:
> > - Rebased on latest QEMU master
> > - Added maintainer entry for Goldfish RTC
> >
> > Changes since v4:
> > - Fixed typo in trace event usage
> > - Moved goldfish_rtc.h to correct location
> >
> > Changes since v3:
> > - Address all nit comments from Alistair
> >
> > Changes since v2:
> > - Rebased on RTC code refactoring
> >
> > Changes since v1:
> > - Implemented VMState save/restore callbacks
> >
> > Anup Patel (3):
> > hw: rtc: Add Goldfish RTC device
> > riscv: virt: Use Goldfish RTC device
> > MAINTAINERS: Add maintainer entry for Goldfish RTC
> >
> > MAINTAINERS | 8 +
> > hw/riscv/Kconfig | 1 +
> > hw/riscv/virt.c | 16 ++
> > hw/rtc/Kconfig | 3 +
> > hw/rtc/Makefile.objs | 1 +
> > hw/rtc/goldfish_rtc.c | 285 ++++++++++++++++++++++++++++++++++
> > hw/rtc/trace-events | 4 +
> > include/hw/riscv/virt.h | 2 +
> > include/hw/rtc/goldfish_rtc.h | 46 ++++++
> > 9 files changed, 366 insertions(+)
> > create mode 100644 hw/rtc/goldfish_rtc.c
> > create mode 100644 include/hw/rtc/goldfish_rtc.h
>
> Thanks. I've updated the patches on my queue, LMK if there are any more
> changes!
Can this series be taken for QEMU 5.0 ?
It's already 2 months since it was reviewed.
Regards,
Anup
prev parent reply other threads:[~2020-01-22 11:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-06 11:56 [PATCH v8 0/3] RTC support for QEMU RISC-V virt machine Anup Patel
2019-11-06 11:56 ` [PATCH v8 1/3] hw: rtc: Add Goldfish RTC device Anup Patel
2019-11-06 11:56 ` [PATCH v8 2/3] riscv: virt: Use " Anup Patel
2019-11-06 11:56 ` [PATCH v8 3/3] MAINTAINERS: Add maintainer entry for Goldfish RTC Anup Patel
2019-11-07 16:52 ` [PATCH v8 0/3] RTC support for QEMU RISC-V virt machine Palmer Dabbelt
2019-11-07 18:04 ` Philippe Mathieu-Daudé
2020-01-22 11:43 ` Anup Patel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAhSdy2QAcRz42uHC+DvBZ5mrzZ8Drz59Ps3_TPKB-8EDeh-uQ@mail.gmail.com \
--to=anup@brainfault.org \
--cc=Alistair.Francis@wdc.com \
--cc=Anup.Patel@wdc.com \
--cc=Atish.Patra@wdc.com \
--cc=kbastian@mail.uni-paderborn.de \
--cc=palmer@dabbelt.com \
--cc=palmer@sifive.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=sagark@eecs.berkeley.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).