qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: Jason Wang <jasowang@redhat.com>
Cc: Helge Deller <deller@gmx.de>,
	QEMU Developers <qemu-devel@nongnu.org>,
	Richard Henderson <rth@twiddle.net>
Subject: Re: [PATCH] hw/net/i82596.c: Avoid reading off end of buffer in i82596_receive()
Date: Thu, 26 Mar 2020 21:11:38 +0000	[thread overview]
Message-ID: <CAFEAcA8GMPAgxJrHwJZDWOmCWRnTPxb7+9UoAJqZAMpnWxXu=g@mail.gmail.com> (raw)
In-Reply-To: <a550ff78-f639-4048-ba2b-20cea1915d83@redhat.com>

On Tue, 17 Mar 2020 at 06:13, Jason Wang <jasowang@redhat.com> wrote:
> On 2020/3/13 上午4:16, Peter Maydell wrote:
> > The i82596_receive() function attempts to pass the guest a buffer
> > which is effectively the concatenation of the data it is passed and a
> > 4 byte CRC value.  However, rather than implementing this as "write
> > the data; then write the CRC" it instead bumps the length value of
> > the data by 4, and writes 4 extra bytes from beyond the end of the
> > buffer, which it then overwrites with the CRC.  It also assumed that
> > we could always fit all four bytes of the CRC into the final receive
> > buffer, which might not be true if the CRC needs to be split over two
> > receive buffers.

> Applied.

Hi Jason -- this doesn't seem to have reached master yet.
Has it gotten lost somewhere along the line?

thanks
-- PMM


  parent reply	other threads:[~2020-03-26 21:12 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-12 20:16 [PATCH] hw/net/i82596.c: Avoid reading off end of buffer in i82596_receive() Peter Maydell
2020-03-17  6:13 ` Jason Wang
2020-03-17 19:06   ` Helge Deller
2020-03-26 21:11   ` Peter Maydell [this message]
2020-03-27  2:10     ` Jason Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFEAcA8GMPAgxJrHwJZDWOmCWRnTPxb7+9UoAJqZAMpnWxXu=g@mail.gmail.com' \
    --to=peter.maydell@linaro.org \
    --cc=deller@gmx.de \
    --cc=jasowang@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).