From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A2BEC433F5 for ; Mon, 13 Sep 2021 11:52:58 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9040D60FA0 for ; Mon, 13 Sep 2021 11:52:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9040D60FA0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:42594 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mPkW8-0003QR-K7 for qemu-devel@archiver.kernel.org; Mon, 13 Sep 2021 07:52:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40802) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mPkSq-0000A5-R7 for qemu-devel@nongnu.org; Mon, 13 Sep 2021 07:49:32 -0400 Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]:43617) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mPkSp-0008IM-A9 for qemu-devel@nongnu.org; Mon, 13 Sep 2021 07:49:32 -0400 Received: by mail-wr1-x42f.google.com with SMTP id b6so14198631wrh.10 for ; Mon, 13 Sep 2021 04:49:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=GDHrVdxoq0ovrAkHvH9Qo7YGWd/Zy0Kwy/fWHQ0Jmiw=; b=kvMxcdSyqj9A1niPKSYIj0eCSZ+X4hCu8CYdBKLILMisKCsLKHwSzVNcon9IXkFtoE GF++hM1hKJJEXx+H/XX8BFNltG0QApkRQxTpV6OPkWBZ1aiSH7Q43OTkJ+p65Kf5xOMn 4bhBTv3gAFofla4x0210wMsOBsAWal+snZPy8uD3QCcdtlnn9gBO5hUhUpBZKot2pMPj zc01oBTIA752Tpoagb+ZxLo9qr0rTP5NjMZXQDLmAlp0GsYT7AesZ4VkdFBiQ5p/IPJF wQTq7BrSQqQfN5VeU21xIX5iSsbcE3NWbgM7km0bqLDHRSHkCR6X4fmtkUTaw4GDoHqA Q2fA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GDHrVdxoq0ovrAkHvH9Qo7YGWd/Zy0Kwy/fWHQ0Jmiw=; b=K7Yy0jvxmP/2Ua64H0QZ7ZcVZ4b8AYbKieFiPE4b52fh/2TSHurT5VDQSk2Z4lY3iU 4kLIp+ZGOY6cqkHqSwz5CugZz7Ry/4XWwc123l1Z8P9sBJlE7i7wPfEh+sfolh12xOkU egbKPVUk9EcpMFw2E9pKdKXCSO1dg38DF/BhbfKGy1L76stiW3D7eWdPrKKLHhvVmCfv mirptQiO3jv93SdMN8bwdblczerQHtl1aSHer+LeFnU9nHkeA3bwGMOlujZRMyLQxNAI xWJSsjSCp+6nFA18AimDVVuzl75+ql/9L+uC7JEFaqpGu3X+DGSEIyAFpjPTjzfMSlKE T4jw== X-Gm-Message-State: AOAM532veatmZdxbkvkpBCmd+OAndfuuTsJEwmAL1NFx41jbcVzpoT7X NWq9ztnnwRRZxp92exzAK85WGWFnZRYejBPo78SVBg== X-Google-Smtp-Source: ABdhPJzgX+iF/ml4YBefQ5U8gDuK2XNSQIi2t5cCedBUpHBKyzw4Ja69itbBtXAAm1+MtcduKm4cWdEmhbkH+sKd1ac= X-Received: by 2002:adf:fb91:: with SMTP id a17mr11731852wrr.376.1631533769397; Mon, 13 Sep 2021 04:49:29 -0700 (PDT) MIME-Version: 1.0 References: <20210519202253.76782-1-agraf@csgraf.de> <20210519202253.76782-16-agraf@csgraf.de> <45519c63-06b1-1e06-032d-87d2e1338fd8@csgraf.de> <1c992028-633d-5f5e-f433-59492876eb73@csgraf.de> In-Reply-To: From: Peter Maydell Date: Mon, 13 Sep 2021 12:48:39 +0100 Message-ID: Subject: Re: [PATCH v8 15/19] hvf: arm: Implement -cpu host To: Alexander Graf Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2a00:1450:4864:20::42f; envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x42f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eduardo Habkost , =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= , Richard Henderson , QEMU Developers , Cameron Esfahani , Roman Bolshakov , qemu-arm , Frank Yang , Paolo Bonzini , Peter Collingbourne Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, 13 Sept 2021 at 12:46, Alexander Graf wrote: > > > On 13.09.21 12:52, Peter Maydell wrote: > > On Mon, 13 Sept 2021 at 11:46, Alexander Graf wrote: > >> Why? You only get to this code path if you already selected -accel hvf. > >> If even a simple "create scratch vcpu" syscall failed then, pretty > >> failure when you define -cpu host is the last thing you care about. Any > >> CPU creation would fail. > > General design principle -- low level functions should report > > errors upwards, not barf and exit. > > > Usually I would agree with you, but here it really does not make sense > and would make the code significantly harder to read. It's an unnecessary difference from how we've structured the KVM code. I don't like those. Every time you put one in to the code you write you can be fairly sure I'm going to question it during review... I want to be able to look at the hvf code and say "ah, yes, this is just the hvf version of the kvm code we already have". -- PMM