From: Peter Maydell <peter.maydell@linaro.org>
To: Palmer Dabbelt <palmer@sifive.com>,
Alistair Francis <alistair23@gmail.com>
Cc: "open list:RISC-V" <qemu-riscv@nongnu.org>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PULL] RISC-V Patches for 4.2-rc2
Date: Fri, 19 Jul 2019 12:11:10 +0100 [thread overview]
Message-ID: <CAFEAcA9mR5XxV9ghSzt4PbANKZJW1xKMGF1a9+ak+m6OyZ-YZQ@mail.gmail.com> (raw)
In-Reply-To: <CAFEAcA_MGz=EvH67twNoM-SMXZ8_pE6FhO+JuLN=0Z1H6sfRnw@mail.gmail.com>
On Fri, 19 Jul 2019 at 12:03, Peter Maydell <peter.maydell@linaro.org> wrote:
> This passes the 'make check' tests but it prints out a lot
> of warnings as it does so:
>
> qemu-system-riscv64: warning: No -bios option specified. Not loading a firmware.
> qemu-system-riscv64: warning: This default will change in QEMU 4.3.
> Please use the -bios option to aviod breakages when this happens.
> qemu-system-riscv64: warning: See QEMU's deprecation documentation for details
>
> (repeated 7 or 8 times during the course of a test run)
>
> Can we make the tests not trigger warnings, please?
> (I have a filter where I search through for strings like
> "warning" because warnings that shouldn't happen often don't
> actually cause the tests to fail.)
Forgot to mention, but a common way to do this is to say
"don't print the warnings about bios image loading if
qtest_enabled(), because with qtest we never execute any
guest code anyway". That will probably fix the warnings here.
> Also, I notice that you have a typo: "aviod" should be "avoid".
Also also, the warning message mentions "QEMU 4.3", but our
versioning system bumps the major version every year, so
the pending release is 4.1, the next one will be 4.2, and
then the release after that will be 5.0 because it will be the
first release in 2020.
(Plus, your merge commit message says this pullreq is
for 4.2-rc2, which is a typo for 4.1-rc2 I assume.)
Since this pullreq does pass the tests, and rc2 is not far off
now (Tuesday), I think my suggestion is that I'll apply this
as-is, and we should fix up the issues with the warning messages
as a followup patch. I think that's better than holding this
out of master and making it risk missing rc2.
thanks
-- PMM
next prev parent reply other threads:[~2019-07-19 11:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-19 1:58 [Qemu-devel] [PULL] RISC-V Patches for 4.2-rc2 Palmer Dabbelt
2019-07-19 1:58 ` [Qemu-devel] [PULL 1/2] roms: Add OpenSBI version 0.4 Palmer Dabbelt
2019-07-19 1:58 ` [Qemu-devel] [PULL 2/2] hw/riscv: Load OpenSBI as the default firmware Palmer Dabbelt
2019-07-19 11:03 ` [Qemu-devel] [PULL] RISC-V Patches for 4.2-rc2 Peter Maydell
2019-07-19 11:11 ` Peter Maydell [this message]
2019-07-19 11:52 ` Peter Maydell
2019-07-19 16:16 ` Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA9mR5XxV9ghSzt4PbANKZJW1xKMGF1a9+ak+m6OyZ-YZQ@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=alistair23@gmail.com \
--cc=palmer@sifive.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).