From: Peter Maydell <peter.maydell@linaro.org>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: qemu-arm <qemu-arm@nongnu.org>, QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v5 3/5] target/arm: handle A-profile semihosting at translate time
Date: Fri, 13 Sep 2019 14:04:05 +0100 [thread overview]
Message-ID: <CAFEAcA_NCz_qFFFOShV8ktV4vHeYezQ=5S7QQPTMQywGfY1FGw@mail.gmail.com> (raw)
In-Reply-To: <20190911164959.11003-4-alex.bennee@linaro.org>
On Wed, 11 Sep 2019 at 17:50, Alex Bennée <alex.bennee@linaro.org> wrote:
>
> As for the other semihosting calls we can resolve this at translate
> time.
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>
> ---
> v2
> - update for change to gen_exception_internal_insn API
> v3
> - update for decode tree, merge T32 & A32 commits
> - dropped r-b due to changes
> v4
> - !IS_USER and !arm_dc_feature(s, ARM_FEATURE_M)
> v5
> - only if !IS_USER for softmmu, linux-user is still allowed
> ---
> target/arm/translate.c | 19 +++++++++++++++----
> 1 file changed, 15 insertions(+), 4 deletions(-)
>
> diff --git a/target/arm/translate.c b/target/arm/translate.c
> index 6689acc911e..fac791c4b06 100644
> --- a/target/arm/translate.c
> +++ b/target/arm/translate.c
> @@ -10219,14 +10219,25 @@ static bool trans_CBZ(DisasContext *s, arg_CBZ *a)
> }
>
> /*
> - * Supervisor call
> + * Supervisor call - both T32 & A32 come here so we need to check
> + * which mode we are in when checking for semihosting.
> */
>
> static bool trans_SVC(DisasContext *s, arg_SVC *a)
> {
> - gen_set_pc_im(s, s->base.pc_next);
> - s->svc_imm = a->imm;
> - s->base.is_jmp = DISAS_SWI;
> + const uint32_t semihost_imm = s->thumb ? 0xab : 0x123456;
> +
> + if (!arm_dc_feature(s, ARM_FEATURE_M) && semihosting_enabled() &&
> +#ifndef CONFIG_USER_ONLY
> + !IS_USER(s) &&
> +#endif
> + (a->imm == semihost_imm)) {
> + gen_exception_internal_insn(s, s->base.pc_next, EXCP_SEMIHOST);
> + } else {
> + gen_set_pc_im(s, s->base.pc_next);
> + s->svc_imm = a->imm;
> + s->base.is_jmp = DISAS_SWI;
> + }
> return true;
> }
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
next prev parent reply other threads:[~2019-09-13 13:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-11 16:49 [Qemu-devel] [PATCH v5 0/5] semihosting cleanups (plus minor tests/tcg tweak) Alex Bennée
2019-09-11 16:49 ` [Qemu-devel] [PATCH v5 1/5] tests/tcg: clean-up some comments after the de-tangling Alex Bennée
2019-09-13 13:02 ` Peter Maydell
2019-09-11 16:49 ` [Qemu-devel] [PATCH v5 2/5] target/arm: handle M-profile semihosting at translate time Alex Bennée
2019-09-13 13:03 ` Peter Maydell
2019-09-13 13:28 ` Alex Bennée
2019-09-13 13:31 ` Peter Maydell
2019-09-13 13:48 ` Peter Maydell
2019-09-13 13:48 ` Alex Bennée
2019-09-11 16:49 ` [Qemu-devel] [PATCH v5 3/5] target/arm: handle A-profile " Alex Bennée
2019-09-13 13:04 ` Peter Maydell [this message]
2019-09-11 16:49 ` [Qemu-devel] [PATCH v5 4/5] target/arm: remove run time semihosting checks Alex Bennée
2019-09-11 16:49 ` [Qemu-devel] [PATCH v5 5/5] target/arm: remove run-time semihosting checks for linux-user Alex Bennée
2019-09-13 13:05 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA_NCz_qFFFOShV8ktV4vHeYezQ=5S7QQPTMQywGfY1FGw@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).