From: Han Han <hhan@redhat.com>
To: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org, laurent@vivier.eu
Subject: Re: [PATCH] Revert "qemu-options.hx: Update for reboot-timeout parameter"
Date: Thu, 5 Dec 2019 10:49:13 +0800 [thread overview]
Message-ID: <CAHjf+S_qH0MSxQX+A98uVi5iFYPvLd-dzAoArkPFovYGFvLs6A@mail.gmail.com> (raw)
In-Reply-To: <20191204122140.GI3325@work-vm>
[-- Attachment #1: Type: text/plain, Size: 1541 bytes --]
OK. Updated in version 2.
On Wed, Dec 4, 2019 at 8:21 PM Dr. David Alan Gilbert <dgilbert@redhat.com>
wrote:
> * Han Han (hhan@redhat.com) wrote:
> > This reverts commit bbd9e6985ff342cbe15b9cb7eb30e842796fbbe8.
>
> Patchew spotted you're missing the signed-off-by; please send one.
>
> Dave
>
> > In 20a1922032 we allowed reboot-timeout=-1 again, so update the doc
> > accordingly.
> > ---
> > qemu-options.hx | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/qemu-options.hx b/qemu-options.hx
> > index 65c9473b73..e14d88e9b2 100644
> > --- a/qemu-options.hx
> > +++ b/qemu-options.hx
> > @@ -327,8 +327,8 @@ format(true color). The resolution should be
> supported by the SVGA mode, so
> > the recommended is 320x240, 640x480, 800x640.
> >
> > A timeout could be passed to bios, guest will pause for
> @var{rb_timeout} ms
> > -when boot failed, then reboot. If @option{reboot-timeout} is not set,
> > -guest will not reboot by default. Currently Seabios for X86
> > +when boot failed, then reboot. If @var{rb_timeout} is '-1', guest will
> not
> > +reboot, qemu passes '-1' to bios by default. Currently Seabios for X86
> > system support it.
> >
> > Do strict boot via @option{strict=on} as far as firmware/BIOS
> > --
> > 2.24.0.rc1
> >
> --
> Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
>
>
--
Best regards,
-----------------------------------
Han Han
Quality Engineer
Redhat.
Email: hhan@redhat.com
Phone: +861065339333
[-- Attachment #2: Type: text/html, Size: 2356 bytes --]
prev parent reply other threads:[~2019-12-05 2:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-04 8:56 [PATCH] Revert "qemu-options.hx: Update for reboot-timeout parameter" Han Han
2019-12-04 11:53 ` no-reply
2019-12-04 12:16 ` Markus Armbruster
2019-12-04 12:21 ` Dr. David Alan Gilbert
2019-12-05 2:49 ` Han Han [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHjf+S_qH0MSxQX+A98uVi5iFYPvLd-dzAoArkPFovYGFvLs6A@mail.gmail.com \
--to=hhan@redhat.com \
--cc=dgilbert@redhat.com \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).