From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1313C433DB for ; Thu, 25 Mar 2021 20:33:18 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 35B7861A3F for ; Thu, 25 Mar 2021 20:33:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 35B7861A3F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:55378 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lPWfN-0004gX-7H for qemu-devel@archiver.kernel.org; Thu, 25 Mar 2021 16:33:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59868) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lPWdG-0003oV-Ok for qemu-devel@nongnu.org; Thu, 25 Mar 2021 16:31:06 -0400 Received: from mail-ed1-x534.google.com ([2a00:1450:4864:20::534]:45596) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lPWdD-000344-VO for qemu-devel@nongnu.org; Thu, 25 Mar 2021 16:31:06 -0400 Received: by mail-ed1-x534.google.com with SMTP id bx7so3857933edb.12 for ; Thu, 25 Mar 2021 13:31:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=MFY+Hq6FshLxgaDPnG6cxFXCjFy2KN+LBJXAWBWKOtk=; b=BXxkNAEcSpvfa/s/wZnCRp6EuNRdEc9tOI1JhFrM4fovq8Q5O4MncA27jPoTPdCbrT /qh77PvGcCq4A19GlPF9I2u4IbJbmsGxyQd/++y3KX1rorq+o9m1shWe7x82btyn+jCE rf88bWP/zv6Ba5+gBu4PcFi6FJl43oiKwrzkT7mqU3WNH/DuLxKXt/IXNqEHNHZhRF1v ft+lZ9lgZiCqhI8l6VXpFF1IRuMFBHYNcubrJwZxd0JBoB7/W+g3Udn/ZPMVPjXYHGGx ZWkCfzI4PapO/9nekwzjA1R8DQkzuj1CbHnkdFTw12ViQWDIySWn1iBrjEMdzDxel+so EE0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MFY+Hq6FshLxgaDPnG6cxFXCjFy2KN+LBJXAWBWKOtk=; b=bIyNosfnm1iFIuqPsko/FurXwm3GGGmnwkiq8IC5gmTTlOKEF8ZlYgrKApf9rSHZCM rurn3dBS71KVPQA/avndTdGNLlBk39WXBVhNFfXPHWGTIwnVjhLdchIZTrXgnMehTWZC 0Gb80ekTCMz2JScxOftkW5xC/lYopi64KvCywQqlyk1Zuh4alHpTKTrNlU78YJ3qHO8Y TB3iQ6jmaMMoRpWd6zjhdn2R3cYyYPcc3e1S8OZjlmz6Ma4dm8EC05wAcxlsqPWyEGP7 8G9X1nJF/P6EuskULqxfqM2a7DgZxSgDLeWa6v4eIvn7j/Nd6lR7mYWIRcLVrFDqbo3g Yyjg== X-Gm-Message-State: AOAM532QjNTanFjHfm6AkAuVlBUarw28HoL8ol2c16iEczJaKduhup2n NfEkpnzdGqynkUtU+09JyrZ1qFL5VeyCyYUKqbc= X-Google-Smtp-Source: ABdhPJzj8bVmaNapkC8afDBfP4IGpB/ziaV4141onZblKIhnc8A1+pI3oXJvYJR+DCD9VAsp7wxoa4uC77r8Q49faCA= X-Received: by 2002:a05:6402:31b7:: with SMTP id dj23mr11368386edb.245.1616704261549; Thu, 25 Mar 2021 13:31:01 -0700 (PDT) MIME-Version: 1.0 References: <997aa12a28c555d8a3b7a363b3bda5c3cf1821ba.1616521341.git.lukasstraub2@web.de> In-Reply-To: <997aa12a28c555d8a3b7a363b3bda5c3cf1821ba.1616521341.git.lukasstraub2@web.de> From: =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= Date: Fri, 26 Mar 2021 00:30:49 +0400 Message-ID: Subject: Re: [PATCH 2/2] yank: Always link full yank code To: Lukas Straub Content-Type: multipart/alternative; boundary="0000000000003771f105be624bff" Received-SPF: pass client-ip=2a00:1450:4864:20::534; envelope-from=marcandre.lureau@gmail.com; helo=mail-ed1-x534.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , Thomas Huth , Alex Bennee , qemu-devel , Markus Armbruster Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --0000000000003771f105be624bff Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Mar 23, 2021 at 9:57 PM Lukas Straub wrote: > Yank now only depends on util and can be always linked in. Also remove > the stubs as they are not needed anymore. > > Signed-off-by: Lukas Straub > Reviewed-by: Marc-Andr=C3=A9 Lureau --- > MAINTAINERS | 1 - > stubs/meson.build | 1 - > stubs/yank.c | 23 ----------------------- > util/meson.build | 2 +- > 4 files changed, 1 insertion(+), 26 deletions(-) > delete mode 100644 stubs/yank.c > > diff --git a/MAINTAINERS b/MAINTAINERS > index 455775c4a3..77259c031d 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -2820,7 +2820,6 @@ Yank feature > M: Lukas Straub > S: Odd fixes > F: util/yank.c > -F: stubs/yank.c > F: migration/yank_functions* > F: include/qemu/yank.h > F: qapi/yank.json > diff --git a/stubs/meson.build b/stubs/meson.build > index 8a3e804cf0..be6f6d609e 100644 > --- a/stubs/meson.build > +++ b/stubs/meson.build > @@ -46,7 +46,6 @@ stub_ss.add(files('vm-stop.c')) > stub_ss.add(files('win32-kbd-hook.c')) > stub_ss.add(files('cpu-synchronize-state.c')) > if have_block > - stub_ss.add(files('yank.c')) > stub_ss.add(files('replay-tools.c')) > endif > if have_system > diff --git a/stubs/yank.c b/stubs/yank.c > deleted file mode 100644 > index 11b24fc057..0000000000 > --- a/stubs/yank.c > +++ /dev/null > @@ -1,23 +0,0 @@ > -#include "qemu/osdep.h" > -#include "qemu/yank.h" > - > -bool yank_register_instance(const YankInstance *instance, Error **errp) > -{ > - return true; > -} > - > -void yank_unregister_instance(const YankInstance *instance) > -{ > -} > - > -void yank_register_function(const YankInstance *instance, > - YankFn *func, > - void *opaque) > -{ > -} > - > -void yank_unregister_function(const YankInstance *instance, > - YankFn *func, > - void *opaque) > -{ > -} > diff --git a/util/meson.build b/util/meson.build > index 984fba965f..510765cde4 100644 > --- a/util/meson.build > +++ b/util/meson.build > @@ -43,6 +43,7 @@ util_ss.add(files('stats64.c')) > util_ss.add(files('systemd.c')) > util_ss.add(when: 'CONFIG_POSIX', if_true: files('drm.c')) > util_ss.add(files('guest-random.c')) > +util_ss.add(files('yank.c')) > > if have_user > util_ss.add(files('selfmap.c')) > @@ -51,7 +52,6 @@ endif > if have_system > util_ss.add(files('crc-ccitt.c')) > util_ss.add(when: 'CONFIG_GIO', if_true: [files('dbus.c'), gio]) > - util_ss.add(files('yank.c')) > util_ss.add(when: 'CONFIG_LINUX', if_true: files('userfaultfd.c')) > endif > > -- > 2.30.2 > --=20 Marc-Andr=C3=A9 Lureau --0000000000003771f105be624bff Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Tue, Mar 23, 2021 at 9:57 PM Lukas= Straub <lukasstraub2@web.de&= gt; wrote:
Yank = now only depends on util and can be always linked in. Also remove
the stubs as they are not needed anymore.

Signed-off-by: Lukas Straub <lukasstraub2@web.de>

Reviewed-by: Marc-Andr=C3=A9 Lureau <marcandre.lureau@redhat.com>=C2=A0
---
=C2=A0MAINTAINERS=C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 1 -
=C2=A0stubs/meson.build |=C2=A0 1 -
=C2=A0stubs/yank.c=C2=A0 =C2=A0 =C2=A0 | 23 -----------------------
=C2=A0util/meson.build=C2=A0 |=C2=A0 2 +-
=C2=A04 files changed, 1 insertion(+), 26 deletions(-)
=C2=A0delete mode 100644 stubs/yank.c

diff --git a/MAINTAINERS b/MAINTAINERS
index 455775c4a3..77259c031d 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2820,7 +2820,6 @@ Yank feature
=C2=A0M: Lukas Straub <lukasstraub2@web.de>
=C2=A0S: Odd fixes
=C2=A0F: util/yank.c
-F: stubs/yank.c
=C2=A0F: migration/yank_functions*
=C2=A0F: include/qemu/yank.h
=C2=A0F: qapi/yank.json
diff --git a/stubs/meson.build b/stubs/meson.build
index 8a3e804cf0..be6f6d609e 100644
--- a/stubs/meson.build
+++ b/stubs/meson.build
@@ -46,7 +46,6 @@ stub_ss.add(files('vm-stop.c'))
=C2=A0stub_ss.add(files('win32-kbd-hook.c'))
=C2=A0stub_ss.add(files('cpu-synchronize-state.c'))
=C2=A0if have_block
-=C2=A0 stub_ss.add(files('yank.c'))
=C2=A0 =C2=A0stub_ss.add(files('replay-tools.c'))
=C2=A0endif
=C2=A0if have_system
diff --git a/stubs/yank.c b/stubs/yank.c
deleted file mode 100644
index 11b24fc057..0000000000
--- a/stubs/yank.c
+++ /dev/null
@@ -1,23 +0,0 @@
-#include "qemu/osdep.h"
-#include "qemu/yank.h"
-
-bool yank_register_instance(const YankInstance *instance, Error **errp) -{
-=C2=A0 =C2=A0 return true;
-}
-
-void yank_unregister_instance(const YankInstance *instance)
-{
-}
-
-void yank_register_function(const YankInstance *instance,
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 YankFn *func,
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 void *opaque)
-{
-}
-
-void yank_unregister_function(const YankInstance *instance,
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 YankFn *func,
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 void *opaque)
-{
-}
diff --git a/util/meson.build b/util/meson.build
index 984fba965f..510765cde4 100644
--- a/util/meson.build
+++ b/util/meson.build
@@ -43,6 +43,7 @@ util_ss.add(files('stats64.c'))
=C2=A0util_ss.add(files('systemd.c'))
=C2=A0util_ss.add(when: 'CONFIG_POSIX', if_true: files('drm.c&#= 39;))
=C2=A0util_ss.add(files('guest-random.c'))
+util_ss.add(files('yank.c'))

=C2=A0if have_user
=C2=A0 =C2=A0util_ss.add(files('selfmap.c'))
@@ -51,7 +52,6 @@ endif
=C2=A0if have_system
=C2=A0 =C2=A0util_ss.add(files('crc-ccitt.c'))
=C2=A0 =C2=A0util_ss.add(when: 'CONFIG_GIO', if_true: [files('d= bus.c'), gio])
-=C2=A0 util_ss.add(files('yank.c'))
=C2=A0 =C2=A0util_ss.add(when: 'CONFIG_LINUX', if_true: files('= userfaultfd.c'))
=C2=A0endif

--
2.30.2


--
Marc-Andr=C3=A9 Lureau
--0000000000003771f105be624bff--